Skip to content

iommu/amd: Refactors for ATS robustness

Pranjal Shrivastava linux-iommu linux-pci lkml 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest4 patches 4 repliesIn review
  2. v35 patches 33 repliesSuperseded
  3. v25 patches 9 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v16 patches7 repliesSuperseded

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4iommu/amd: Refactor device probe and capability initializationdrivers/iommu/amd/iommu.c+59 -580 replies
2/4iommu/amd: Remove iommu_ignore_device()drivers/iommu/amd/iommu.c+2 -222 replies
3/4iommu/amd: Fail probe on ATS configuration failuredrivers/iommu/amd/iommu.c+29 -100 replies
4/4PCI/ATS: Mandate checking pci_ats_supported() before pci_prepare_ats()drivers/pci/ats.c+4 -20 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchJason GunthorpeVasant HegdeSamiullah KhawajaNicolin Chen
1/4R-b R-b
2/4R-b R-b
3/4R-b R-b R-b
4/4R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v4 thread

Cover letter [PATCH v4 0/4] iommu/amd: Refactors for ATS robustness

This series forms the second half of the subsystem-wide ATS robustness updates. The first part (focusing on the core subsystem, Intel, and ARM SMMUv3) has already been merged upstream [1]. This half addresses the AMD IOMMU driver and standardizes the PCI ATS API.

In v2, the series has been significantly restructured based on feedback on v1.

[v4]
- https://lore.kernel.org/all/[email protected]/
- Dropped iommu_ignore_device() and dropped patch 3 per discussion with Jason and Vasant.
- Renamed iommu_lookup_device() to lookup_device().
- Cleaned up amd_iommu_probe_device() to return error pointers directly.
- Collected Reviewed-by tags from Jason, Vasant and Sami.

[v3]
- Collected Reviewed-by tags from Vasant.
- Added a comment explaining why devices without DMA translation support are not ignored (to preserve interrupt remapping) per Vasant's feedback.
- Renamed iommu_disable_device_dma() to iommu_disable_device() to accurately reflect that it disables both DMA and interrupt remapping.

[v2]
- https://lore.kernel.org/all/[email protected]/
- Patch 1 Refctors the probe path, isolating capabilities into iommu_init_device_caps().
- Patch 2 renames iommu_ignore_device() to iommu_disable_device_dma(). Following Jason's suggestion, it invalidates the hardware DTE by clearing the Valid bit (lower 128 bits) followed by the upper 128 bits.
- Patch 3 splits the probe error paths to ensure that devices with config failures (like PD_MODE_NONE or ATS mismatches) can preserve their rlookup_table entries, successfully keeping IRQ remapping functional for bypassed devices.
- Patch 4 implements the "Fail Hard" pattern for ATS in the AMD driver, failing the probe and throwing a WARN_ON() upon ATS configuration or enablement failures.
- Patch 5 enforces the checking of pci_ats_supported() prior to calling pci_prepare_ats() across the entire kernel PCI subsystem.

[v1]
- https://lore.kernel.org/all/[email protected]/

Thanks,
Praan

[1] https://lore.kernel.org/all/[email protected]/

Pranjal Shrivastava (4):
iommu/amd: Refactor device probe and capability initialization iommu/amd: Remove iommu_ignore_device()
iommu/amd: Fail probe on ATS configuration failure PCI/ATS: Mandate checking pci_ats_supported() before pci_prepare_ats()

 drivers/iommu/amd/iommu.c | 164 +++++++++++++++++++-------------------
 drivers/pci/ats.c         |   6 +-
 2 files changed, 86 insertions(+), 84 deletions(-)
Signature · 1 line
2.55.0.1003.g10538fe699-goog