Skip to content

ASoC: Intel: catpt: Code cleanup

Cezary Rojewski linux-sound 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest7 patches 1 replyIn review
  2. v27 patches 2 repliesSuperseded
  3. v17 patches 10 repliesSuperseded

Changes in v3 from the cover letter

- reworded commit message for 5/7 patch to avoid any ambiguity
- the mute-boolean is now declared explicitly
- spaced out the code a little
- added Andy's Reviewed-by: tag

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7ASoC: Intel: catpt: Utilize lock-guard helpersound/soc/intel/catpt/dsp.c sound/soc/intel/catpt/ipc.c+6 -150 replies
2/7ASoC: Intel: catpt: Replace RAM-helpers with resource_xxx()sound/soc/intel/catpt/core.h sound/soc/intel/catpt/device.c sound/soc/intel/catpt/loader.c+4 -130 replies
3/7ASoC: Intel: catpt: Simplify the RAM-navigation codesound/soc/intel/catpt/dsp.c sound/soc/intel/catpt/registers.h+5 -30 replies
4/7ASoC: Intel: catpt: Simplify catpt_stream_find()sound/soc/intel/catpt/pcm.c+6 -100 replies
5/7ASoC: Intel: catpt: Remove unused WAVES controlssound/soc/intel/catpt/pcm.c+0 -320 replies
6/7ASoC: Intel: catpt: Drop manipulation of the obsolete direction flagsound/soc/intel/catpt/dsp.c+0 -10 replies
7/7ASoC: Intel: catpt: Cleanup components_kcontrols[]sound/soc/intel/catpt/pcm.c+7 -80 replies

Reviews trailers per patch

All 7 patches have a Reviewed-by or Acked-by.

PatchAndy Shevchenko
1/7R-b
2/7R-b
3/7R-b
4/7R-b
5/7R-b
6/7R-b
7/7R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/7] ASoC: Intel: catpt: Code cleanup

All of the changes found here are cleanups and from functional perspective, have no impact - either unused code is being removed or existing code is altered to use helpers/macros to improve readability.

Collateral of recent fixes [1]. There is one more patchset with similar goal following this one. Before the team managed to actually fix the problem, a number of changes were added to make the code easier to understand for people who are not the author (me).

[1]: https://lore.kernel.org/linux-sound/[email protected]/

Changes in v3:
- reworded commit message for 5/7 patch to avoid any ambiguity
- the mute-boolean is now declared explicitly
- spaced out the code a little
- added Andy's Reviewed-by: tag

Changes in v2:
- removed the header declaration for
catpt_sram_init() as suggested by Mark

Cezary Rojewski (7):
ASoC: Intel: catpt: Utilize lock-guard helper
ASoC: Intel: catpt: Replace RAM-helpers with resource_xxx()
ASoC: Intel: catpt: Simplify the RAM-navigation code
ASoC: Intel: catpt: Simplify catpt_stream_find()
ASoC: Intel: catpt: Remove unused WAVES controls
ASoC: Intel: catpt: Drop manipulation of the obsolete direction flag
ASoC: Intel: catpt: Cleanup components_kcontrols[]

 sound/soc/intel/catpt/core.h      |  1 -
 sound/soc/intel/catpt/device.c    |  9 ++---
 sound/soc/intel/catpt/dsp.c       | 19 ++++------
 sound/soc/intel/catpt/ipc.c       |  9 +----
 sound/soc/intel/catpt/loader.c    |  7 +---
 sound/soc/intel/catpt/pcm.c       | 63 +++++++------------------------
 sound/soc/intel/catpt/registers.h |  2 +
 7 files changed, 28 insertions(+), 82 deletions(-)
Signature · 1 line
2.34.1