ASoC: Intel: catpt: Code cleanup
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest7 patches 1 replyIn review
- v27 patches 2 repliesSuperseded
- v17 patches 10 repliesSuperseded
Changes in v3 from the cover letter
- reworded commit message for 5/7 patch to avoid any ambiguity
- the mute-boolean is now declared explicitly
- spaced out the code a little
- added Andy's Reviewed-by: tag
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | ASoC: Intel: catpt: Utilize lock-guard helpersound/ sound/ | +6 | 0 replies | |
| 2/7 | ASoC: Intel: catpt: Replace RAM-helpers with resource_xxx()sound/ sound/ sound/ | +4 | 0 replies | |
| 3/7 | ASoC: Intel: catpt: Simplify the RAM-navigation codesound/ sound/ | +5 | 0 replies | |
| 4/7 | ASoC: Intel: catpt: Simplify catpt_stream_find()sound/ | +6 | 0 replies | |
| 5/7 | ASoC: Intel: catpt: Remove unused WAVES controlssound/ | +0 | 0 replies | |
| 6/7 | ASoC: Intel: catpt: Drop manipulation of the obsolete direction flagsound/ | +0 | 0 replies | |
| 7/7 | ASoC: Intel: catpt: Cleanup components_kcontrols[]sound/ | +7 | 0 replies |
Reviews trailers per patch
All 7 patches have a Reviewed-by or Acked-by.
| Patch | Andy Shevchenko |
|---|---|
| 1/7 | R-b |
| 2/7 | R-b |
| 3/7 | R-b |
| 4/7 | R-b |
| 5/7 | R-b |
| 6/7 | R-b |
| 7/7 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v3 0/7] ASoC: Intel: catpt: Code cleanup
All of the changes found here are cleanups and from functional perspective, have no impact - either unused code is being removed or existing code is altered to use helpers/macros to improve readability.
Collateral of recent fixes [1]. There is one more patchset with similar goal following this one. Before the team managed to actually fix the problem, a number of changes were added to make the code easier to understand for people who are not the author (me).
[1]: https://lore.kernel.org/linux-sound/[email protected]/
Changes in v3:
- reworded commit message for 5/7 patch to avoid any ambiguity
- the mute-boolean is now declared explicitly
- spaced out the code a little
- added Andy's Reviewed-by: tag
Changes in v2:
- removed the header declaration for
catpt_sram_init() as suggested by Mark
Cezary Rojewski (7):
ASoC: Intel: catpt: Utilize lock-guard helper
ASoC: Intel: catpt: Replace RAM-helpers with resource_xxx()
ASoC: Intel: catpt: Simplify the RAM-navigation code
ASoC: Intel: catpt: Simplify catpt_stream_find()
ASoC: Intel: catpt: Remove unused WAVES controls
ASoC: Intel: catpt: Drop manipulation of the obsolete direction flag
ASoC: Intel: catpt: Cleanup components_kcontrols[]
sound/soc/intel/catpt/core.h | 1 - sound/soc/intel/catpt/device.c | 9 ++--- sound/soc/intel/catpt/dsp.c | 19 ++++------ sound/soc/intel/catpt/ipc.c | 9 +---- sound/soc/intel/catpt/loader.c | 7 +--- sound/soc/intel/catpt/pcm.c | 63 +++++++------------------------ sound/soc/intel/catpt/registers.h | 2 + 7 files changed, 28 insertions(+), 82 deletions(-)
Signature · 1 line
2.34.1