Skip to content

numa: add unit testing plus fix regression

Roger Pau Monne xen-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest5 patches 8 repliesIn review
  2. v15 patches 15 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5tools/bitops: adjust bitmap_or() interface to match hypervisortools/include/xen-tools/bitops.h tools/libs/guest/xg_sr_save.c+6 -40 replies
2/5tools/macros: adjust ROUNDUP() interface to match hypervisortools/console/daemon/io.c tools/include/xen-tools/common-macros.h tools/libs/call/buffer.c +19 more+45 -452 replies
3/5xen/numa: prepare NUMA setup code for unit testingxen/common/numa.c+9 -50 replies
4/5tests/numa: add unit tests for NUMA setup logictools/tests/Makefile tools/tests/numa/.gitignore tools/tests/numa/Makefile +2 more+456 -05 replies
5/5xen/numa: fix setup of non-aligned memory affinity rangestools/include/xen-tools/common-macros.h tools/tests/numa/test-numa.c xen/common/numa.c+52 -01 reply

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchAnthony PERARDJan Beulich
1/5A-b
2/5R-b
3/5A-b
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH for-4.22 v2 0/5] numa: add unit testing plus fix regression

Hello,

The first 4 patches add some basic unit testing for the NUMA setup logic. The last patch expands the test cases and fixes an issue the new test-cases would otherwise trigger.

Only patch 4 is missing an Ack or Reviewed by.

Thanks, Roger.

Roger Pau Monne (5):
tools/bitops: adjust bitmap_or() interface to match hypervisor tools/macros: adjust ROUNDUP() interface to match hypervisor xen/numa: prepare NUMA setup code for unit testing tests/numa: add unit tests for NUMA setup logic xen/numa: fix setup of non-aligned memory affinity ranges

 tools/console/daemon/io.c                 |   2 +-
 tools/include/xen-tools/bitops.h          |   7 +-
 tools/include/xen-tools/common-macros.h   |   5 +-
 tools/libs/call/buffer.c                  |   3 +-
 tools/libs/foreignmemory/linux.c          |   2 +-
 tools/libs/gnttab/freebsd.c               |   2 +-
 tools/libs/gnttab/linux.c                 |   2 +-
 tools/libs/guest/xg_core.c                |   2 +-
 tools/libs/guest/xg_dom_arm.c             |   6 +-
 tools/libs/guest/xg_dom_x86.c             |   2 +-
 tools/libs/guest/xg_private.h             |   4 +-
 tools/libs/guest/xg_sr_common.c           |   6 +-
 tools/libs/guest/xg_sr_save.c             |   3 +-
 tools/libs/guest/xg_sr_stream_format.h    |   2 +-
 tools/libs/light/libxl_arm_acpi.c         |  24 +-
 tools/libs/light/libxl_create.c           |   2 +-
 tools/libs/light/libxl_sr_stream_format.h |   2 +-
 tools/libs/light/libxl_stream_read.c      |   2 +-
 tools/libs/light/libxl_stream_write.c     |   4 +-
 tools/misc/xen-mfndump.c                  |   2 +-
 tools/ocaml/libs/xc/xenctrl_stubs.c       |   2 +-
 tools/tests/Makefile                      |   1 +
 tools/tests/numa/.gitignore               |   2 +
 tools/tests/numa/Makefile                 |  47 ++++
 tools/tests/numa/harness.h                | 184 +++++++++++++++
 tools/tests/numa/test-numa.c              | 267 ++++++++++++++++++++++
 tools/xenstored/core.c                    |   4 +-
 tools/xenstored/domain.c                  |   9 +-
 tools/xenstored/watch.c                   |   2 +-
 xen/common/numa.c                         |  20 +-
 30 files changed, 568 insertions(+), 54 deletions(-)
 create mode 100644 tools/tests/numa/.gitignore
 create mode 100644 tools/tests/numa/Makefile
 create mode 100644 tools/tests/numa/harness.h
 create mode 100644 tools/tests/numa/test-numa.c
Signature · 1 line
2.53.0