resolve_btfids: Implement BTF tags emission for kfuncs
Status from this message: This series was applied to bpf/bpf-next.git (master)
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest6 patches 0 repliesApplied 6/6
- v26 patches 17 repliesSuperseded
- v114 patches 35 repliesSuperseded
Changes in v3 from the cover letter
* Refactoring in patch #2 (Eduard)
* restructure add_arena_tagged_proto() such that first we copy the func proto and then update param types in place
* push error messages down to arena_tag_ptr()
* introduce is_arena_arg() helper
* Docs cleanup in patch #6 (Eduard)
* Add stats in commit message for patch #1
v2: https://lore.kernel.org/bpf/[email protected]/
Patches in v3 All 6 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | resolve_btfids: Deduplicate BTF after btf2btf transformationstools/ | +6 | 0 replies | Applied |
| 2/6 | resolve_btfids: Process KF_ARENA_* flags in resolve_btfidsscripts/ tools/ | +134 | 0 replies | Applied |
| 3/6 | selftests/bpf: Verify arena type tags in resolve_btfids testtools/ tools/ | +76 | 0 replies | Applied |
| 4/6 | resolve_btfids: Emit bpf_kfunc and bpf_fastcall decl tagsscripts/ tools/ | +31 | 0 replies | Applied |
| 5/6 | selftests/bpf: Verify decl tags emission in resolve_btfids testtools/ | +40 | 0 replies | Applied |
| 6/6 | docs, resolve_btfids: Document kfunc BTF annotation emissionDocumentation/ Documentation/ tools/ | +18 | 0 replies | Applied |
Reviews trailers per patch
4 of 6 patches have a Reviewed-by or Acked-by.
| Patch | Eduard Zingerman | Emil Tsalapatis |
|---|---|---|
| 1/6 | ||
| 2/6 | ||
| 3/6 | A-b | |
| 4/6 | A-b | |
| 5/6 | A-b | |
| 6/6 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH bpf-next v3 0/6] resolve_btfids: Implement BTF tags emission for kfuncs
BTF data for the kernel is generated through the following pipeline:
* DWARF is emitted by the compiler
* pahole reads in DWARF and produces BTF
* resolve_btfids makes kernel-specific btf2btf transformation and patches .BTF_ids section
This is orchestrated by link-vmlinux.sh, gen-btf.sh and Makefile.btf in ./scripts directory.
Historically kernel-specific BTF features were implemented in pahole, and controlled by the feature flags. This requires kernel build process to be aware of pahole version used for the build to set correct runtime arguments for BTF encoding [1].
This is a burden which can be alleviated by splitting kernel/module BTF generation in two stages:
1. Generic BTF generation from the kernel source code.
2. Kernel-specific BTF modifications to support various BPF features.
So far both stages were fused in pahole's BTF encoding. By moving stage (2) in-tree, the dependency of kernel build on pahole can become much more loose.
resolve_btfids is already responsible for a few kernel-specific BTF modifications:
* .BTF.base generation for modules [2]
* BTF sorting [3]
* KF_IMPLICIT_ARGS support [4]
This series completes the migration by emitting BTF kfunc annotations
in-tree: the "bpf_kfunc" and "bpf_fastcall" decl tags and the arena "address_space(1)" type attribute, dropping the corresponding pahole feature flags.
The three annotations depend on two pahole feature flags:
"decl_tag_kfuncs" and "attributes". Since emission is unconditional, each flag has to be dropped in the same commit as the emission that replaces it.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/scripts/Makefile.btf?h=v7.1-rc5
[2] https://docs.kernel.org/bpf/btf.html#btf-base-section
[3] https://lore.kernel.org/bpf/[email protected]/
[4] https://lore.kernel.org/bpf/[email protected]/
[5] https://lore.kernel.org/bpf/[email protected]/
[6] https://lore.kernel.org/bpf/[email protected]/
---
v2->v3:
* Refactoring in patch #2 (Eduard)
* restructure add_arena_tagged_proto() such that first we copy the func proto and then update param types in place
* push error messages down to arena_tag_ptr()
* introduce is_arena_arg() helper
* Docs cleanup in patch #6 (Eduard)
* Add stats in commit message for patch #1
v2: https://lore.kernel.org/bpf/[email protected]/
v1->v2:
* The bottom part of v1 has already been landed [5][6].
* New patch #1: run btf__dedup() in finalize_btf().
* Drop the "ensure" pattern. Emission is unconditional; kbuild owns the pahole flags, so assume input BTF is not already tagged.
* Each pahole flag is now dropped in the same commit as the emission that replaces it.
* Fail hard with an error on invalid kfunc declarations such as an arena flag naming a missing argument or a non-pointer type.
* Various cleanups and nits (Andrii, Emil, Jiri, Sashiko).
v1: https://lore.kernel.org/bpf/[email protected]/
---
Ihor Solodrai (6):
resolve_btfids: Deduplicate BTF after btf2btf transformations
resolve_btfids: Process KF_ARENA_* flags in resolve_btfids selftests/bpf: Verify arena type tags in resolve_btfids test
resolve_btfids: Emit bpf_kfunc and bpf_fastcall decl tags selftests/bpf: Verify decl tags emission in resolve_btfids test docs, resolve_btfids: Document kfunc BTF annotation emission
Documentation/bpf/kfuncs.rst | 7 + Documentation/process/changes.rst | 5 - scripts/Makefile.btf | 4 +- tools/bpf/resolve_btfids/main.c | 185 +++++++++++++++++- .../selftests/bpf/prog_tests/resolve_btfids.c | 106 ++++++++++ tools/testing/selftests/bpf/progs/btf_data.c | 10 + 6 files changed, 304 insertions(+), 13 deletions(-)
Signature · 1 line
2.55.0