Skip to content

Convert shell-based ACL test (tacl_xattr.sh) to C

Sachin Sant ltp 12 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v12 Latest8 patches 3 repliesIn review
  2. v118 patches 1 replySuperseded
  3. v108 patches 5 repliesSuperseded
Earlier versions · 9
VersionPostedPatchesRepliesStatus
v98 patches1 replySuperseded
v88 patches1 replySuperseded
v78 patches1 replySuperseded
v68 patches1 replySuperseded
v52 of 8 patches4 repliesSuperseded
v42 of 8 patches5 repliesSuperseded
v33 of 8 patches1 replySuperseded
v23 of 8 patches2 repliesSuperseded
v18 patches2 repliesSuperseded

Changes in v12 from the cover letter

Updated patch 6/8. Rest of the patches remain unchanged.

Patches in v12 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8fs/acl: Add ACL_USER_OBJ permission testruntest/fs testcases/kernel/fs/acl/.gitignore testcases/kernel/fs/acl/Makefile +2 more+648 -03 replies
2/8fs/acl: Add ACL mask interaction testsruntest/fs testcases/kernel/fs/acl/.gitignore testcases/kernel/fs/acl/acl_mask01.c+177 -00 replies
3/8fs/acl: Add ACL_OTHER permission testruntest/fs testcases/kernel/fs/acl/.gitignore testcases/kernel/fs/acl/acl_other01.c+106 -00 replies
4/8fs/acl: Add default ACL inheritance testruntest/fs testcases/kernel/fs/acl/.gitignore testcases/kernel/fs/acl/acl_inherit01.c+115 -00 replies
5/8fs/acl: Add chmod/chown ACL interaction testsruntest/fs testcases/kernel/fs/acl/.gitignore testcases/kernel/fs/acl/acl_file_ops01.c+266 -00 replies
6/8fs/acl: Add ACL symlink operations testruntest/fs testcases/kernel/fs/acl/.gitignore testcases/kernel/fs/acl/acl_link01.c+216 -00 replies
7/8fs/acl: Add extended attributes testruntest/fs testcases/kernel/fs/acl/.gitignore testcases/kernel/fs/acl/xattr_test01.c+382 -00 replies
8/8fs/acl: Remove old shell-based ACL testtestcases/kernel/fs/acl/tacl_xattr.sh+0 -8070 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v12 yet.

Read the v12 thread

Cover letter [LTP] [PATCH v12 0/8] Convert shell-based ACL test (tacl_xattr.sh) to C

This patch series converts the existing shell-based ACL test (tacl_xattr.sh) to C implementation, providing better integration with the LTP test framework and more precise control over test execution.

v11 -> v12
Updated patch 6/8. Rest of the patches remain unchanged.

v10 -> v11
Updated patches 1/8 and 5/8. Rest of the patches remain unchanged.

v9 -> v10
Updated patch 2/8 to incorporate review comments. Rest of the patches remain unchanged.

v8 -> v9
Updated patches 1, 2, 5, and 7 to incorporate review comments.

v7 -> v8
Updated patches 1, 5, 6 and 7 to incorporate review comments.

v6 -> v7
Updated 1/8 to address review comments. Rest of the patches in the series remain unchanged.

v5 -> v6
Updated patches 1 to 7 to address review comments. Added HAVE_SYS_XATTR_H guards for systems without xattr support

v4 -> v5
Updated patches 1 to 7 to address review comments. Tests rely on kernel only implementation and removes dependeny on acl library and useradd/del commands

v3 -> v4
Updated patches 1/8, 4/8 & 6/8 to address review comments. No changes to other patches in the series.

v2 -> v3
Updated patches 1 through 7 to address review comments.

v1 -> v2
Updated patches 1/8, 6/8 and 7/8 to address review comments. Remaining patches remain unchanged

Addresses part of issue #1265

The conversion splits functionality into seven focused test files. Patch 1/8 adds acl_user_obj01.c
Patch 2/8 adds acl_mask01.c
Patch 3/8 adds acl_other01.c
Patch 4/8 adds acl_inherit01.c
Patch 5/8 adds acl_file_ops01.c
Patch 6/8 adds acl_link01.c
Patch 7/8 adds xattr_test01.c

The code has been successfully tested on SLES (kernel 6.12) and fedora (kernel 7.0) releases on ppc64le arch.

Test build is clean in various linux distribution releases. CI build report at https://github.com/sacsant/ltp/actions/runs/27553802425

Sachin Sant (8):
fs/acl: Add ACL_USER_OBJ permission test
fs/acl: Add ACL mask interaction tests
ifs/acl: Add ACL_OTHER permission test
fs/acl: Add default ACL inheritance test
fs/acl: Add chmod/chown ACL interaction tests
fs/acl: Add ACL symlink operations test
fs/acl: Add extended attributes test
fs/acl: Remove old shell-based ACL test

 runtest/fs                               |   9 +
 testcases/kernel/fs/acl/.gitignore       |   7 +
 testcases/kernel/fs/acl/Makefile         |   8 +
 testcases/kernel/fs/acl/acl_file_ops01.c | 264 ++++++++
 testcases/kernel/fs/acl/acl_inherit01.c  | 113 ++++
 testcases/kernel/fs/acl/acl_lib.h        | 509 ++++++++++++++
 testcases/kernel/fs/acl/acl_link01.c     | 215 ++++++
 testcases/kernel/fs/acl/acl_mask01.c     | 175 +++++
 testcases/kernel/fs/acl/acl_other01.c    | 104 +++
 testcases/kernel/fs/acl/acl_user_obj01.c | 127 ++++
 testcases/kernel/fs/acl/tacl_xattr.sh    | 807 -----------------------
 testcases/kernel/fs/acl/xattr_test01.c   | 380 +++++++++++
 12 files changed, 1911 insertions(+), 807 deletions(-)
 create mode 100644 testcases/kernel/fs/acl/.gitignore
 create mode 100644 testcases/kernel/fs/acl/Makefile
 create mode 100644 testcases/kernel/fs/acl/acl_file_ops01.c
 create mode 100644 testcases/kernel/fs/acl/acl_inherit01.c
 create mode 100644 testcases/kernel/fs/acl/acl_lib.h
 create mode 100644 testcases/kernel/fs/acl/acl_link01.c
 create mode 100644 testcases/kernel/fs/acl/acl_mask01.c
 create mode 100644 testcases/kernel/fs/acl/acl_other01.c
 create mode 100644 testcases/kernel/fs/acl/acl_user_obj01.c
 delete mode 100755 testcases/kernel/fs/acl/tacl_xattr.sh
 create mode 100644 testcases/kernel/fs/acl/xattr_test01.c
Signature · 5 lines
2.39.1


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp