Skip to content

drm/xe: Allow pushing more jobs into LRC.

Maarten Lankhorst intel-xe 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 1 replyIn review
  2. v2 RFC2 patches 0 repliesSuperseded
  3. v1 RFC2 patches 0 repliesSuperseded

Changes in v3 from the cover letter

- Fix job submission.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2drm/xe: Convert job preparation in 2 stagesdrivers/gpu/drm/xe/xe_ring_ops.c drivers/gpu/drm/xe/xe_ring_ops_types.h drivers/gpu/drm/xe/xe_sched_job.c +1 more+97 -651 reply
2/2drm/xe: Set job credits based on LRC sizedrivers/gpu/drm/xe/xe_execlist.c drivers/gpu/drm/xe/xe_guc_submit.c drivers/gpu/drm/xe/xe_sched_job.c+7 -50 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [CI v3 0/2] drm/xe: Allow pushing more jobs into LRC.

We don't know beforehand how big a job will be, so we always assume the worst case scenario and fill the LRC based on that.

Try an alternative approach, where we determine the space required in LRC right before submitting the job and pass that info to the drm scheduler. This does increase the size of xe_sched_job slightly, but does allow a bigger queue depth.

Noticed when rebasing Matt Brost's series where queue depth dropped below 64.

Changes since v2:
- Fix job submission.

Maarten Lankhorst (2):
drm/xe: Convert job preparation in 2 stages
drm/xe: Set job credits based on LRC size

 drivers/gpu/drm/xe/xe_execlist.c        |   2 +-
 drivers/gpu/drm/xe/xe_guc_submit.c      |   2 +-
 drivers/gpu/drm/xe/xe_ring_ops.c        | 150 ++++++++++++++----------
 drivers/gpu/drm/xe/xe_ring_ops_types.h  |   3 +
 drivers/gpu/drm/xe/xe_sched_job.c       |  10 +-
 drivers/gpu/drm/xe/xe_sched_job_types.h |   5 +
 6 files changed, 103 insertions(+), 69 deletions(-)
Signature · 1 line
2.53.0