Skip to content

serial: mxs-auart: devm conversion, clock rework, and IRQ ordering fixes

Rosen Penev imx linux-arm-kernel linux-serial lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest6 patches 5 repliesIn review
  2. v24 patches 5 repliesSuperseded
  3. v13 patches 2 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6serial: mxs-auart: fix cast type for of_device_get_match_datadrivers/tty/serial/mxs-auart.c+1 -11 reply
2/6serial: mxs-auart: rework clock handling in mxs_get_clks and probedrivers/tty/serial/mxs-auart.c+17 -300 replies
3/6serial: mxs-auart: use devm resources for iomem and GPIO IRQsdrivers/tty/serial/mxs-auart.c+11 -421 reply
4/6serial: mxs-auart: fix IRQ registration ordering and manage console clockdrivers/tty/serial/mxs-auart.c+39 -100 replies
5/6serial: mxs-auart: clamp RX DMA count to buffer sizedrivers/tty/serial/mxs-auart.c+1 -11 reply
6/6serial: mxs-auart: terminate DMA before releasing channels in exitdrivers/tty/serial/mxs-auart.c+2 -01 reply

Reviews trailers per patch

1 of 6 patches has a Reviewed-by or Acked-by.

PatchFrank Li
1/6
2/6
3/6
4/6
5/6
6/6R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCHv3 0/6] serial: mxs-auart: devm conversion, clock rework, and IRQ ordering fixes

This series cleans up the mxs-auart driver by converting to devm-managed resources, fixing clock prepare/enable ordering, and addressing IRQ registration races.

Patch 1 fixes compilation on 64-bit build with W=1

Patch 2 reworks the clock handling to use devm_clk_get_enabled and reorders clk_prepare_enable after clk_set_rate to avoid CLK_SET_RATE_GATE failures.

Patch 3 converts iomem mapping and GPIO IRQ requests to devm, removing the manual cleanup paths.

Patch 4 moves the main UART IRQ registration after uart_add_one_port so the port state is initialized before the handler can run, and manages the module clock for console vs non-console ports correctly.

v3: two more sashiko fixes
v2: split off of_device_get_match_data change.

Rosen Penev (6):
serial: mxs-auart: fix cast type for of_device_get_match_data
serial: mxs-auart: rework clock handling in mxs_get_clks and probe
serial: mxs-auart: use devm resources for iomem and GPIO IRQs
serial: mxs-auart: fix IRQ registration ordering and manage console
clock
serial: mxs-auart: clamp RX DMA count to buffer size
serial: mxs-auart: terminate DMA before releasing channels in exit

 drivers/tty/serial/mxs-auart.c | 145 +++++++++++++++------------------
 1 file changed, 66 insertions(+), 79 deletions(-)

--
2.54.0