Skip to content

watchdog: pika_wdt: portability and timer lifecycle fixes

Rosen Penev linux-watchdog lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 4 repliesIn review
  2. v22 patches 0 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2watchdog: pika_wdt: fix timer lifecycle bugsdrivers/watchdog/pika_wdt.c+3 -11 reply
2/2watchdog: pika_wdt: enable COMPILE_TEST buildsdrivers/watchdog/Kconfig drivers/watchdog/pika_wdt.c+6 -53 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCHv3 0/2] watchdog: pika_wdt: portability and timer lifecycle fixes

Fix two timer lifecycle bugs in the PIKA watchdog driver:

- pikawdt_release() could race with a concurrent open() due to clearing the open bit before stopping the timer.
- pikawdt_exit() unmapped FPGA memory without stopping the ping timer first, potentially executing the handler on freed memory.

Then replace powerpc-specific I/O accessors with generic ones to allow COMPILE_TEST builds on other architectures.

v3: fix sashiko reported issues
v2: fix preexisting issues

Rosen Penev (2):
watchdog: pika_wdt: fix timer lifecycle bugs
watchdog: pika_wdt: enable COMPILE_TEST builds

 drivers/watchdog/Kconfig    |  3 ++-
 drivers/watchdog/pika_wdt.c | 12 +++++++-----
 2 files changed, 9 insertions(+), 6 deletions(-)

--
2.54.0