Skip to content

media: qcom: camss: vfe-17x: fix wm_done dispatch and silence unmapped-WM noise

Herman van Hazendonk linux-arm-msm linux-media 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2media: qcom: camss: vfe-17x: dispatch wm_done per write masterdrivers/media/platform/qcom/camss/camss-vfe-17x.c+1 -10 replies
2/2media: qcom: camss: vfe-17x: silence wm-done IRQ on unmapped WMsdrivers/media/platform/qcom/camss/camss-vfe-17x.c+22 -70 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] media: qcom: camss: vfe-17x: fix wm_done dispatch and silence unmapped-WM noise

The vfe-17x wm_done IRQ path has two independent bugs fixed here:

PATCH 1/2 fixes a gate condition in the wm_done dispatch loop that used a constant BIT(9) — STATUS_0_IMAGE_MASTER_PING_PONG(1) — instead of the per-WM macro STATUS_0_IMAGE_MASTER_PING_PONG(wm). As a result only write master 1 ever had its wm_done callback fired; every other write master's interrupt was silently dropped, stalling any video stream not routed through WM 1.

PATCH 2/2 moves the VFE_LINE_NONE check ahead of the output spinlock in vfe_isr_wm_done(). Write masters allocated to statistics or other secondary paths are not mapped to an output line; the existing code took the spinlock before noticing this and printed a rate-limited error each time. The fix returns silently before acquiring the lock, eliminating harmless but noisy dmesg spam on such configurations.

Herman van Hazendonk (2):
media: qcom: camss: vfe-17x: dispatch wm_done per write master
media: qcom: camss: vfe-17x: silence wm-done IRQ on unmapped WMs

 .../media/platform/qcom/camss/camss-vfe-17x.c | 31 ++++++++++++++-----
 1 file changed, 23 insertions(+), 8 deletions(-)
Signature · 1 line
2.43.0