Skip to content

of: reserved_mem: fix OOB write and name skipped nodes

Sang-Heon Jeon linux-devicetree sashiko-reviews 2 versions – Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 3 repliesApplied
  2. v11 patch 2 repliesSuperseded

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/2of: reserved_mem: prevent OOB when too many dynamic regions are defineddrivers/of/of_reserved_mem.c+11 -31 reply
2/2of: reserved_mem: print skipped node name when too many regions are defineddrivers/of/of_reserved_mem.c+2 -12 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/2] of: reserved_mem: fix OOB write and name skipped nodes

Patch 1 fixes an out-of-bounds write in fdt_scan_reserved_mem(). When more than MAX_RESERVED_REGIONS dynamically-placed regions are defined, it writes past the end of the local array.

Patch 2 names the skipped node in fdt_init_reserved_mem_node(), the other place that drops regions.

Changes from v1 [1]
- fix bounds check to cover the missed case in v1, based on sashiko review
- print skipped no name error message in fdt_scan_reserved_mem() and fdt_init_reserved_mem_node() both.

[1] https://lore.kernel.org/all/[email protected]/

Sang-Heon Jeon (2):
of: reserved_mem: prevent OOB when too many dynamic regions are
defined
of: reserved_mem: print skipped node name when too many regions are
defined

 drivers/of/of_reserved_mem.c | 17 +++++++++++++----
 1 file changed, 13 insertions(+), 4 deletions(-)
Signature · 1 line
2.43.0