Skip to content

cxl/pci: Fix the incorrect check of pci_config_read/write*() returns

Dave Jiang linux-cxl 2 versions – Applied

Status from this message: merged to cxl/next

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 2 repliesApplied
  2. v12 patches 11 repliesSuperseded

Changes in v2 from the cover letter

- Fixed up additional bits (Alison)
- Fix up fixes tag (Alison)

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/2cxl/pci: Fix the incorrect check of pci_read_config_word() returndrivers/cxl/core/pci.c+4 -40 replies
2/2cxl/pci: Convert PCIBIOS errors to errno on DVSEC config accessesdrivers/cxl/core/pci.c+9 -91 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchRichard ChengJonathan CameronAlison Schofield
1/2R-b R-b R-b
2/2R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [PATCH v2 0/2] cxl/pci: Fix the incorrect check of pci_config_read/write*() returns

v2:
- Fixed up additional bits (Alison)
- Fix up fixes tag (Alison)

The patches are inspired by comments from Richard Cheng WRT pci config accessors return PCIBIOS errors that are positive integers rather than negative errnos. I went and audited the cxl PCI code and found a few locations that need to be fixed. There are other locations that may trigger issues, but at this point we'll fix them as they happen.

Dave Jiang (2):
cxl/pci: Fix the incorrect check of pci_read_config_word() return cxl/pci: Convert PCIBIOS errors to errno on DVSEC config accesses

 drivers/cxl/core/pci.c | 26 +++++++++++++-------------
 1 file changed, 13 insertions(+), 13 deletions(-)

base-commit: e43ffb69e0438cddd72aaa30898b4dc446f664f8

Signature · 1 line
2.54.0