Skip to content

SO_TXTIME improvements

Willem de Bruijn netdev 2 versions – Applied

Status from this message: This series was applied to netdev/net-next.git (main)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 0 repliesApplied 3/3
  2. v13 patches 4 repliesSuperseded

Patches in v2 All 3 applied

#Subject and filesSizeRepliesApplied
1/3net: ensure SCM_TXTIME delivery time is no older than system bootnet/core/sock.c+31 -10 repliesApplied
2/3net_sched: sch_fq: convert skb->tstamp if not monotonicnet/sched/sch_fq.c+38 -50 repliesApplied
3/3selftests: drv-net: extend so_txtime with FQ with other clockstools/testing/selftests/drivers/net/so_txtime.py+14 -40 repliesApplied

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH net-next v2 0/3] SO_TXTIME improvements

From: Willem de Bruijn <[email protected]>

FQ targets monotonic timestamps as generated by the TCP stack.

But SO_TXTIME was later added, which can send skbs with timestamps against other clocks. It is now possible to detect these through skb tstamp_type.

Make FQ robust by converting these timestamps for use in FQ (patch 2).

This also requires testing against out-of-bounds values. Prefer to do this at the source, when parsing SCM_TXTIME (patch 1). But, tests in the hot path are still needed, to handle BPF sources.

Extend the so_txtime selftest to handle this new case (patch 3).

Changes: see individual patches
Previous versions:
v1: https://lore.kernel.org/netdev/[email protected]/

Willem de Bruijn (3):
net: ensure SCM_TXTIME delivery time is no older than system boot
net_sched: sch_fq: convert skb->tstamp if not monotonic
selftests: drv-net: extend so_txtime with FQ with other clocks

 net/core/sock.c                               | 32 +++++++++++++-
 net/sched/sch_fq.c                            | 43 ++++++++++++++++---
 .../selftests/drivers/net/so_txtime.py        | 18 ++++++--
 3 files changed, 83 insertions(+), 10 deletions(-)
Signature · 1 line
2.54.0.1032.g2f8565e1d1-goog