Skip to content

gpu: nova-core: fb: Hopper sysmem flush fix and cleanups

John Hubbard lkml nova-gpu 2 versions – Applied

Status from this message: Pushed to drm-rust-next, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 1 replyApplied
  2. v12 patches 4 repliesSuperseded

Changes in v2 from the cover letter

* Split the original single patch into two: a no-functional-change patch that makes the GB20x FBHUB0 flush registers absolute, followed by the Hopper fix.

* Made the FBHUB0 registers absolute instead of relative to a register base window, per Alexandre Courbot's review.

* Dropped the "clean up FSP FRTS comments" patch, because it has already been applied to drm-rust-next.

* Added a third patch with two tiny readability cleanups: compose the Blackwell flush address as (hi << 32) | lo, and drop a duplicated SysmemFlush doc link.

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/3gpu: nova-core: Blackwell: use absolute FBHUB0 flush registersdrivers/gpu/nova-core/fb/hal/gb202.rs drivers/gpu/nova-core/regs.rs+15 -300 replies
2/3gpu: nova-core: Hopper: use correct sysmem flush registersdrivers/gpu/nova-core/fb/hal/gh100.rs drivers/gpu/nova-core/regs.rs+47 -30 replies
3/3gpu: nova-core: fb: two tiny readability cleanupsdrivers/gpu/nova-core/fb/hal/gb202.rs drivers/gpu/nova-core/regs.rs+2 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/3] gpu: nova-core: fb: Hopper sysmem flush fix and cleanups

Changes in v2:

* Split the original single patch into two: a no-functional-change patch that makes the GB20x FBHUB0 flush registers absolute, followed by the Hopper fix.

* Made the FBHUB0 registers absolute instead of relative to a register base window, per Alexandre Courbot's review.

* Dropped the "clean up FSP FRTS comments" patch, because it has already been applied to drm-rust-next.

* Added a third patch with two tiny readability cleanups: compose the Blackwell flush address as (hi << 32) | lo, and drop a duplicated SysmemFlush doc link.

John Hubbard (3):
gpu: nova-core: Blackwell: use absolute FBHUB0 flush registers
gpu: nova-core: Hopper: use correct sysmem flush registers
gpu: nova-core: fb: two tiny readability cleanups

 drivers/gpu/nova-core/fb/hal/gb202.rs | 28 ++++++-------------
 drivers/gpu/nova-core/fb/hal/gh100.rs | 31 +++++++++++++++++++--
 drivers/gpu/nova-core/regs.rs         | 40 +++++++++++++++++++--------
 3 files changed, 64 insertions(+), 35 deletions(-)

base-commit: 550dc7536644db2d67c6f8cf525bba682fba08d9

Signature · 1 line
2.54.0