Skip to content

memory: fsl_ifc: Switch to modern devm and platform IRQ APIs

Rosen Penev lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 6 repliesIn review
  2. v13 patches 7 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4memory: fsl_ifc: Fix optional NAND IRQ handling and migrate to platform IRQ APIdrivers/memory/fsl_ifc.c+21 -225 replies
2/4memory: fsl_ifc: Use devm_platform_ioremap_resource and fix error pathsdrivers/memory/fsl_ifc.c+9 -141 reply
3/4memory: fsl_ifc: Use devm_request_irq and simplify removedrivers/memory/fsl_ifc.c+12 -350 replies
4/4memory: fsl_ifc: drop simple-bus emulationdrivers/memory/fsl_ifc.c+1 -90 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCHv2 0/4] memory: fsl_ifc: Switch to modern devm and platform IRQ APIs

Convert the Freescale IFC controller driver from legacy OF-specific APIs to modern platform-device and devm-based equivalents. This eliminates manual resource tracking in error paths and remove(), simplifying the driver and reducing LoC by ~40%.

Patch 1 replaces irq_of_parse_and_map() with platform_get_irq() / platform_get_irq_optional() and fixes unconditional free_irq() calls on the optional NAND IRQ.
Patch 2 replaces of_iomap() with devm_platform_ioremap_resource(), dropping the manual iounmap in remove/error paths and fixing a missing free_irq on the main IRQ request_irq failure. Patch 3 switches from request_irq to devm_request_irq, removing the error-path labels entirely and reducing remove() to just of_platform_depopulate.
Patch 4 removes of_platform_default_populate.

Rosen Penev (4):
memory: fsl_ifc: Fix optional NAND IRQ handling and migrate to
platform IRQ API
memory: fsl_ifc: Use devm_platform_ioremap_resource and fix error
paths
memory: fsl_ifc: Use devm_request_irq and simplify remove
memory: fsl_ifc: drop simple-bus emulation

 drivers/memory/fsl_ifc.c | 101 +++++++++++++--------------------------
 1 file changed, 32 insertions(+), 69 deletions(-)
Signature · 1 line
2.55.0