gpu: nova-core: boot GSP with vGPU enabled on
Status from this message: Merged into drm-rust-next, thanks! With two minor edits:
Get series with b4
b4 am [email protected]Versions newest first
v3 from the cover letter
- Consolidate GSP boot parameters into GspBootContext struct, passed through the HAL trait methods instead of individual arguments.
- Add vGPU preludes patch (VgpuManager, Architecture::supports_vgpu, GspBootContext fields) as preparation for the vGPU boot changes.
- Rebase on top of the latest drm-rust-next.
8 of 9 patches are in this archive. The cover letter announces 9.
Patches in v1 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/9 | rust: pci: expose sriov_get_totalvfs() helperrust/ | +12 | 2 replies | |
| 2/9 | gpu: nova-core: factor out common FSP message headerdrivers/ | +40 | 1 reply | |
| 3/9 | gpu: nova-core: return FSP response buffer to callerdrivers/ | +4 | 4 replies | |
| 4/9 | gpu: nova-core: read vGPU mode from FSP via PRC protocoldrivers/ drivers/ | +148 | 2 replies | |
| 5/9 | gpu: nova-core: add FSP and PRC protocol documentationDocumentation/ Documentation/ | +143 | 3 replies | |
| 6/9 | gpu: nova-core: consolidate GSP boot parameters into GspBootContextdrivers/ drivers/ drivers/ +3 more | +85 | 2 replies | |
| 7/9 | gpu: nova-core: add vGPU preludesdrivers/ drivers/ drivers/ +3 more | +82 | 1 reply | |
| 8/9 | gpu: nova-core: set RMSetSriovMode when NVIDIA vGPU is enableddrivers/ drivers/ drivers/ | +67 | 1 reply |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/9] gpu: nova-core: boot GSP with vGPU enabled on
Booting up GSP with vGPU enabled is part of the first milestone (M1) together with rust fwctl abstraction [1] and nova-core fwctl driver [2] for upstream vGPU support, allowing us to validate the basic GSP boot flow with vGPU enabled, upload vGPU types even before the remaining nova-core dependencies are ready. The nova-vgpu WIP patches for all milestones can be found at [3].
v3:
- Consolidate GSP boot parameters into GspBootContext struct, passed through the HAL trait methods instead of individual arguments.
- Add vGPU preludes patch (VgpuManager, Architecture::supports_vgpu, GspBootContext fields) as preparation for the vGPU boot changes.
- Rebase on top of the latest drm-rust-next.
Dropped patches:
Dependencies still in progress:
- "populate GSP_VF_INFO when vGPU is enabled" - depends on the ExtSriovCapability abstraction [4] which is still under review and Gary's on-going io projection work [5].
Ada specific:
- "introduce vgpu_support module param" - select vGPU support based on module params.
- "load the scrubber ucode when vGPU support is enabled"
v2:
- Adopt early-return style (Dirk).
- Add #ifndef CONFIG_PCI_IOV helper to fix compilation when CONFIG_PCI_IOV is disabled, per (Alex).
- Change return type from Result<i32> to Result<u16> to match the PCI spec field width, avoiding try_from at call sites.
- GspVfInfo changed to tuple struct (Alex).
- Use unconditional constructor with Option wrapping instead of bool parameter. (Alex)
- Use full initialization expression instead of mutating a zeroed value.
- Use .chain() pattern in GspSetSystemInfo::init() for optional vGPU info. (Alex)
- Eliminate all magic numbers: add vf_bar_is_64bit() and read_vf_bar64_addr() to ExtSriovCapability using PCI bindings constants (PCI_BASE_ADDRESS_MEM_TYPE_MASK, etc.).
- Use KVec<RegistryEntry> for dynamic registry entry construction instead of hardcoded array (Timur, Joel, Alexandre).
- Replace magic numbers 32/48 with named binding constants MAX_PARTITIONS_WITH_GFID_32VM / MAX_PARTITIONS_WITH_GFID from OpenRM (Alex).
- Use read_poll_timeout() instead of single read for scrubber completion check (Joel).
- Use dev instead of pdev.as_ref() in dev_dbg! (Dirk).
- Change scrubber trigger condition from vgpu_requested to fb_layout.wpr2_heap.len() > SZ_256M, checking actual heap size instead of vGPU flag. (Alex).
[1] https://lore.kernel.org/rust-for-linux/[email protected]/
[2] https://lore.kernel.org/rust-for-linux/[email protected]/
[3] https://github.com/zhiwang-nvidia/nova-core/tree/zhi/nova-vgpu-wip
[4] https://lore.kernel.org/rust-for-linux/[email protected]/
[5] https://lore.kernel.org/rust-for-linux/[email protected]/
Zhi Wang (9):
rust: pci: expose sriov_get_totalvfs() helper
gpu: nova-core: factor out common FSP message header
gpu: nova-core: return FSP response buffer to caller
gpu: nova-core: read vGPU mode from FSP via PRC protocol
gpu: nova-core: add FSP and PRC protocol documentation
gpu: nova-core: consolidate GSP boot parameters into GspBootContext
gpu: nova-core: add vGPU preludes
gpu: nova-core: set RMSetSriovMode when NVIDIA vGPU is enabled
gpu: nova-core: reserve a larger GSP WPR2 heap when vGPU is enabled
Documentation/gpu/nova/core/fsp.rst | 142 +++++++++++++++++ Documentation/gpu/nova/index.rst | 1 + drivers/gpu/nova-core/fb.rs | 17 +- drivers/gpu/nova-core/fsp.rs | 207 ++++++++++++++++++++++--- drivers/gpu/nova-core/gpu.rs | 38 ++++- drivers/gpu/nova-core/gsp.rs | 27 ++++ drivers/gpu/nova-core/gsp/boot.rs | 60 ++++--- drivers/gpu/nova-core/gsp/commands.rs | 93 +++++++---- drivers/gpu/nova-core/gsp/fw.rs | 16 ++ drivers/gpu/nova-core/gsp/hal.rs | 23 +-- drivers/gpu/nova-core/gsp/hal/gh100.rs | 22 ++- drivers/gpu/nova-core/gsp/hal/tu102.rs | 31 ++-- drivers/gpu/nova-core/mctp.rs | 3 + drivers/gpu/nova-core/nova_core.rs | 1 + drivers/gpu/nova-core/vgpu.rs | 47 ++++++ rust/kernel/pci.rs | 12 ++ 16 files changed, 608 insertions(+), 132 deletions(-) create mode 100644 Documentation/gpu/nova/core/fsp.rst create mode 100644 drivers/gpu/nova-core/vgpu.rs
Signature · 1 line
2.51.0