Skip to content

CPU binds and ULLS on migration queue

Maarten Lankhorst intel-xe 2 versions New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest24 patches 0 repliesNew
  2. v124 patches 2 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/24drm/xe: Drop struct xe_migrate_pt_update argument from populate/clear vfunsdrivers/gpu/drm/xe/xe_migrate.c drivers/gpu/drm/xe/xe_migrate.h drivers/gpu/drm/xe/xe_pt.c+15 -180 replies
2/24drm/xe: Add xe_migrate_update_pgtables_cpu_execute helperdrivers/gpu/drm/xe/xe_migrate.c+35 -230 replies
3/24drm/xe: Decouple exec queue idle check from LRCdrivers/gpu/drm/xe/xe_exec_queue.c+1 -140 replies
4/24drm/xe: Add job count to GuC exec queue snapshotdrivers/gpu/drm/xe/xe_guc_submit.c drivers/gpu/drm/xe/xe_guc_submit_types.h+4 -00 replies
5/24drm/xe: Update xe_bo_put_deferred arguments to include writeback flagdrivers/gpu/drm/xe/xe_bo.h drivers/gpu/drm/xe/xe_drm_client.c drivers/gpu/drm/xe/xe_pt.c+10 -40 replies
6/24drm/xe: Add XE_BO_FLAG_PUT_VM_ASYNCdrivers/gpu/drm/xe/xe_bo.c drivers/gpu/drm/xe/xe_bo.h+8 -10 replies
7/24drm/xe: Update scheduler job layer to support PT jobsdrivers/gpu/drm/xe/xe_sched_job.c drivers/gpu/drm/xe/xe_sched_job_types.h+88 -350 replies
8/24drm/xe: Add helpers to access PT opsdrivers/gpu/drm/xe/xe_pt.c+45 -200 replies
9/24drm/xe: Add struct xe_pt_job_opsdrivers/gpu/drm/xe/xe_migrate.c drivers/gpu/drm/xe/xe_pt.c drivers/gpu/drm/xe/xe_pt.h +2 more+149 -340 replies
10/24drm/xe: Update GuC submission backend to run PT jobsdrivers/gpu/drm/xe/xe_guc_submit.c drivers/gpu/drm/xe/xe_migrate.c drivers/gpu/drm/xe/xe_migrate.h+52 -60 replies
11/24drm/xe: Store level in struct xe_vm_pgtable_updatedrivers/gpu/drm/xe/xe_pt.c drivers/gpu/drm/xe/xe_pt_types.h+9 -20 replies
12/24drm/xe: Don't use migrate exec queue for page fault bindsdrivers/gpu/drm/xe/xe_migrate.c drivers/gpu/drm/xe/xe_migrate.h drivers/gpu/drm/xe/xe_vm.c+57 -100 replies
13/24drm/xe: Enable CPU binds for jobsdrivers/gpu/drm/xe/xe_bo_types.h drivers/gpu/drm/xe/xe_migrate.c drivers/gpu/drm/xe/xe_pt.c+17 -2350 replies
14/24drm/xe: Remove unused arguments from xe_migrate_pt_update_opsdrivers/gpu/drm/xe/xe_migrate.c drivers/gpu/drm/xe/xe_migrate.h drivers/gpu/drm/xe/xe_pt.c+18 -220 replies
15/24drm/xe: Make bind queues operate cross-tiledrivers/gpu/drm/xe/xe_exec_queue.c drivers/gpu/drm/xe/xe_exec_queue.h drivers/gpu/drm/xe/xe_exec_queue_types.h +6 more+125 -1780 replies
16/24drm/xe: Add CPU bind layerdrivers/gpu/drm/xe/Makefile drivers/gpu/drm/xe/xe_cpu_bind.c drivers/gpu/drm/xe/xe_cpu_bind.h +15 more+816 -7770 replies
17/24drm/xe: Add device flag to enable PT mirroring across tilesdrivers/gpu/drm/xe/xe_device_types.h drivers/gpu/drm/xe/xe_migrate.c drivers/gpu/drm/xe/xe_pci.c +4 more+81 -90 replies
18/24drm/xe: Add xe_hw_engine_write_ring_taildrivers/gpu/drm/xe/xe_hw_engine.c drivers/gpu/drm/xe/xe_hw_engine.h+21 -00 replies
19/24drm/xe: Add ULLS support to LRCdrivers/gpu/drm/xe/xe_lrc.c drivers/gpu/drm/xe/xe_lrc.h drivers/gpu/drm/xe/xe_lrc_types.h+58 -00 replies
20/24drm/xe: Add ULLS migration job support to migration layerdrivers/gpu/drm/xe/xe_exec_queue.c drivers/gpu/drm/xe/xe_exec_queue.h drivers/gpu/drm/xe/xe_migrate.c +4 more+194 -50 replies
21/24drm/xe: Add ULLS migration job support to ring opsdrivers/gpu/drm/xe/xe_ring_ops.c+31 -00 replies
22/24drm/xe: Add ULLS migration job support to GuC submissiondrivers/gpu/drm/xe/xe_guc_submit.c+13 -30 replies
23/24drm/xe: Enter ULLS for migration jobs upon page fault or SVM prefetchdrivers/gpu/drm/xe/xe_pagefault.c drivers/gpu/drm/xe/xe_vm.c+6 -10 replies
24/24drm/xe: Add modparam to enable / disable ULLS on migrate queuedrivers/gpu/drm/xe/xe_debugfs.c drivers/gpu/drm/xe/xe_defaults.h drivers/gpu/drm/xe/xe_device.c +4 more+22 -30 replies

Reviews trailers per patch

7 of 24 patches have a Reviewed-by or Acked-by.

PatchFrancois DugastStuart Summers
1/24R-b
2/24R-b
3/24R-b
4/24R-b
5/24R-b
6/24
7/24
8/24R-b
9/24
10/24
11/24R-b
12/24
13/24
14/24
15/24
16/24
17/24
18/24
19/24
20/24
21/24
22/24
23/24
24/24

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [CI v2 00/24]CPU binds and ULLS on migration queue

Rebase of https://lore.kernel.org/all/[email protected]/

***Small compile fix since series no longer applied after a revert.***

This is a test for CI to check if it's clean. Some small changes have been made to compile on newer kernels.

Of note was that max_jobs < 64 now, so I had to remove an assertion in GuC submission that assumed max_jobs was greater.

I also fixed a SINGAL -> SIGNAL typo.

No reviews or feedback please, I first want to check if the test results from the mostly unmodified patch series are still clean after rebasing, then I can work on addressing the review feedback in the original series.

Matthew Brost (24):
drm/xe: Drop struct xe_migrate_pt_update argument from populate/clear
vfuns
drm/xe: Add xe_migrate_update_pgtables_cpu_execute helper drm/xe: Decouple exec queue idle check from LRC
drm/xe: Add job count to GuC exec queue snapshot
drm/xe: Update xe_bo_put_deferred arguments to include writeback flag drm/xe: Add XE_BO_FLAG_PUT_VM_ASYNC
drm/xe: Update scheduler job layer to support PT jobs drm/xe: Add helpers to access PT ops
drm/xe: Add struct xe_pt_job_ops
drm/xe: Update GuC submission backend to run PT jobs drm/xe: Store level in struct xe_vm_pgtable_update
drm/xe: Don't use migrate exec queue for page fault binds drm/xe: Enable CPU binds for jobs
drm/xe: Remove unused arguments from xe_migrate_pt_update_ops drm/xe: Make bind queues operate cross-tile
drm/xe: Add CPU bind layer
drm/xe: Add device flag to enable PT mirroring across tiles drm/xe: Add xe_hw_engine_write_ring_tail
drm/xe: Add ULLS support to LRC
drm/xe: Add ULLS migration job support to migration layer drm/xe: Add ULLS migration job support to ring ops
drm/xe: Add ULLS migration job support to GuC submission drm/xe: Enter ULLS for migration jobs upon page fault or SVM prefetch drm/xe: Add modparam to enable / disable ULLS on migrate queue

 drivers/gpu/drm/xe/Makefile              |   1 +
 drivers/gpu/drm/xe/xe_bo.c               |   8 +-
 drivers/gpu/drm/xe/xe_bo.h               |  11 +-
 drivers/gpu/drm/xe/xe_bo_types.h         |   2 -
 drivers/gpu/drm/xe/xe_cpu_bind.c         | 296 +++++++++
 drivers/gpu/drm/xe/xe_cpu_bind.h         | 118 ++++
 drivers/gpu/drm/xe/xe_debugfs.c          |   1 +
 drivers/gpu/drm/xe/xe_defaults.h         |   1 +
 drivers/gpu/drm/xe/xe_device.c           |  16 +-
 drivers/gpu/drm/xe/xe_device_types.h     |  11 +
 drivers/gpu/drm/xe/xe_drm_client.c       |   2 +-
 drivers/gpu/drm/xe/xe_exec_queue.c       | 164 ++---
 drivers/gpu/drm/xe/xe_exec_queue.h       |  16 +-
 drivers/gpu/drm/xe/xe_exec_queue_types.h |  20 +-
 drivers/gpu/drm/xe/xe_guc_submit.c       |  78 ++-
 drivers/gpu/drm/xe/xe_guc_submit_types.h |   2 +
 drivers/gpu/drm/xe/xe_hw_engine.c        |  20 +
 drivers/gpu/drm/xe/xe_hw_engine.h        |   1 +
 drivers/gpu/drm/xe/xe_lrc.c              |  51 ++
 drivers/gpu/drm/xe/xe_lrc.h              |   3 +
 drivers/gpu/drm/xe/xe_lrc_types.h        |   4 +
 drivers/gpu/drm/xe/xe_migrate.c          | 595 ++++++-----------
 drivers/gpu/drm/xe/xe_migrate.h          |  93 +--
 drivers/gpu/drm/xe/xe_module.c           |   4 +
 drivers/gpu/drm/xe/xe_module.h           |   1 +
 drivers/gpu/drm/xe/xe_pagefault.c        |   3 +
 drivers/gpu/drm/xe/xe_pci.c              |   2 +
 drivers/gpu/drm/xe/xe_pci_types.h        |   3 +-
 drivers/gpu/drm/xe/xe_pt.c               | 773 ++++++++++++++---------
 drivers/gpu/drm/xe/xe_pt.h               |  12 +-
 drivers/gpu/drm/xe/xe_pt_types.h         |  49 +-
 drivers/gpu/drm/xe/xe_ring_ops.c         |  31 +
 drivers/gpu/drm/xe/xe_sched_job.c        | 100 ++-
 drivers/gpu/drm/xe/xe_sched_job_types.h  |  36 +-
 drivers/gpu/drm/xe/xe_sync.c             |  20 +-
 drivers/gpu/drm/xe/xe_tlb_inval_job.c    |  28 +-
 drivers/gpu/drm/xe/xe_tlb_inval_job.h    |   4 +-
 drivers/gpu/drm/xe/xe_vm.c               | 240 +++----
 drivers/gpu/drm/xe/xe_vm.h               |   3 +
 drivers/gpu/drm/xe/xe_vm_types.h         |  22 +-
 40 files changed, 1660 insertions(+), 1185 deletions(-)
 create mode 100644 drivers/gpu/drm/xe/xe_cpu_bind.c
 create mode 100644 drivers/gpu/drm/xe/xe_cpu_bind.h
Signature · 1 line
2.53.0