Skip to content

perf timechart: Small optimization for backtrace

Namhyung Kim linux-perf-users lkml 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 2 repliesIn review
  2. v14 patches 2 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4perf timechart: Don't pass @event to cat_backtrace()tools/perf/builtin-timechart.c+5 -70 replies
2/4perf timechart: Generate backtrace only if neededtools/perf/builtin-timechart.c+10 -40 replies
3/4perf timechart: Remove unused backtrace in trace_handlertools/perf/builtin-timechart.c+23 -410 replies
4/4perf timechart: Remove unnecessary copy of backtracetools/perf/builtin-timechart.c+18 -70 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/4] perf timechart: Small optimization for backtrace

Hello,

I found an issue int timechart backtrace handling during the last review. The goal is to reduce unnecessary work in generating backtrace string.

v2 changes)
* fix memory leaks when backtrace is not used
* copy backtrace when it's used twice

Thanks,
Namhyung

Namhyung Kim (4):
perf timechart: Don't pass @event to cat_backtrace() perf timechart: Generate backtrace only if needed perf timechart: Remove unused backtrace in trace_handler perf timechart: Remove unnecessary copy of backtrace

 tools/perf/builtin-timechart.c | 107 ++++++++++++++++-----------------
 1 file changed, 52 insertions(+), 55 deletions(-)
Signature · 1 line
2.54.0.1032.g2f8565e1d1-goog