Skip to content

Object relationship tracking refactor followup

Amery Hung bpf netdev 3 versions – Applied

Status from this message: This series was applied to bpf/bpf-next.git (master)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest5 patches 0 repliesApplied 5/5
  2. v25 patches 4 repliesSuperseded
  3. v13 patches 9 repliesApplied 3/3

Changes in v3 from the cover letter

- Fix cleanup in patch 2 (AI bots)

Patches in v3 All 5 applied

#Subject and filesSizeRepliesApplied
1/5bpf: Fix dead error check on acquire_reference() in check_kfunc_callkernel/bpf/verifier.c+2 -10 repliesApplied
2/5bpf: Check acquire_reference() error for "__ref" struct_ops argumentskernel/bpf/verifier.c+7 -30 repliesApplied
3/5bpf: Compare parent_id in refsafe() for REF_TYPE_PTRkernel/bpf/states.c+3 -00 repliesApplied
4/5bpf: Remove WARN_ON_ONCE in check_ids()kernel/bpf/states.c+6 -20 repliesApplied
5/5selftests/bpf: Use bpf_dynptr_slice() to read file dynptr in leak testtools/testing/selftests/bpf/progs/file_reader_fail.c+4 -40 repliesApplied

Reviews trailers per patch

2 of 5 patches have a Reviewed-by or Acked-by.

PatchEduard Zingerman
1/5A-b
2/5
3/5
4/5
5/5A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH bpf-next v3 0/5] Object relationship tracking refactor followup

Hi,

The main patchset refactoring object relationship tracking in the verifier has landed and this is a followup that addresses the remaining feedback in v6 [0].

[0] https://lore.kernel.org/bpf/[email protected]/

v2 -> v3
- Fix cleanup in patch 2 (AI bots)

v1 -> v2
- Add patch 2 fixing silent failure when acquiring reference for struct_ops argument
- Add patch 4 removing WARN_ON_ONCE in check_ids()
- Add fix tags

Amery Hung (5):
bpf: Fix dead error check on acquire_reference() in check_kfunc_call
bpf: Check acquire_reference() error for "__ref" struct_ops arguments
bpf: Compare parent_id in refsafe() for REF_TYPE_PTR
bpf: Remove WARN_ON_ONCE in check_ids()
selftests/bpf: Use bpf_dynptr_slice() to read file dynptr in leak test

 kernel/bpf/states.c                                 | 11 +++++++++--
 kernel/bpf/verifier.c                               | 13 +++++++++----
 .../testing/selftests/bpf/progs/file_reader_fail.c  |  8 ++++----
 3 files changed, 22 insertions(+), 10 deletions(-)
Signature · 1 line
2.53.0-Meta