Skip to content

perf/x86: Miscellaneous PMU bug fixes

Dapeng Mi linux-perf-users lkml stable 4 versions – Applied

Status from this message: The following commit has been merged into the perf/core branch of tip:

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest8 patches 0 repliesApplied
  2. v38 patches 12 repliesApplied
  3. v29 patches 20 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v18 patches19 repliesSuperseded

Changes in v4 from the cover letter

- Patch 5/8: Move intel_pmu_arch_lbr_init() before intel_pmu_check_event_constraints_all() which depends on PMU_FL_BR_CNTR flag which is initialized in intel_pmu_arch_lbr_init() (Sashiko).
- Refine change log, remove markdown format (Peter).

Patches in v4 Applied

#Subject and filesSizeRepliesApplied
1/8perf/x86/intel: Remove anythread_deprecated bit from perf_capabilitiesarch/x86/events/intel/core.c arch/x86/events/perf_event.h+4 -80 replies
2/8perf/x86/intel: Keep cap_user_rdpmc in sync with RDPMC user-disable statearch/x86/events/core.c arch/x86/events/intel/core.c arch/x86/events/perf_event.h+6 -50 replies
3/8perf/x86/intel: Fallback to sw branch type decoding if no hw decodingarch/x86/events/intel/lbr.c+1 -10 replies
4/8perf/x86/intel: Fix kernel address leakages in LBR stackarch/x86/events/intel/lbr.c+9 -30 replies
5/8perf/x86/intel: Validate the return value of intel_pmu_init_hybrid()arch/x86/events/intel/core.c+30 -140 replies
6/8perf/x86/intel: Drop fixed-counter PEBS constraints for baseline PEBSarch/x86/events/intel/ds.c+0 -130 replies
7/8perf/core: Fix kernel register info leak via hardware skidkernel/events/core.c+30 -70 replies
8/8perf/core: Check kernel access when kernel callchains are requestedkernel/events/core.c+3 -10 replies

Reviews trailers per patch

1 of 8 patches has a Reviewed-by or Acked-by.

PatchNamhyung KimZide ChenThomas Falcon
1/8A-b R-b R-b
2/8
3/8
4/8
5/8
6/8
7/8
8/8

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v4 thread

Cover letter [Patch v4 0/8] perf/x86: Miscellaneous PMU bug fixes

This series groups several independent PMU fixes to simplify review and backporting.

Changes:
v3 -> v4:
- Patch 5/8: Move intel_pmu_arch_lbr_init() before intel_pmu_check_event_constraints_all() which depends on PMU_FL_BR_CNTR flag which is initialized in intel_pmu_arch_lbr_init() (Sashiko).
- Refine change log, remove markdown format (Peter).

v2 -> v3:
- Patch 2/8: Directly update PERF_EVENT_FLAG_USER_READ_CNT according to rdpmc user disable state (Peter).
- Patch 3/8: Only keep x86_lbr_type check for the detection of hardware branch type decoding (Peter).
- Patch 4/8: Switch from_plm and to_plm variables order and refine comments (Peter).
- Patch 5/8: Move intel_pmu_arch_lbr_init() after model-specfic PMU initialization to avoid extra kmem cache destroy (Peter).
- Patch 6/8: Improve change log to add more details (Peter).

v1 -> v2:
- Fallback to software branch type decoding if hardware decoding is not suppprted (Sashiko patch 4/9).
- Drop kernel IP for PERF_SAMPLE_IP if exclude_kernel attribute is required (Sashiko, patch 8/9).
- Add kernel access check when kernel callchains are requested (Sashiko, patch 9/9)
- Address Zide and Thomas's comments.
- Collect Reviewed-bys.

Patch layout:
- Patch 1/8: Fix anythread_deprecated being overwritten issue.
- Patch 2/8: Fix the issue that cap_user_rdpmc is not updated correctly.
- Patch 3/8: Fallback to software branch type decoding if no hardware decoding.
- Patch 4/8: Fix the kernel address leakage issue in LBR stack.
- Patch 5/8: Fix the issue that the return value of intel_pmu_init_hybrid() is not valiated correctly.
- Patch 6/8: Fix a "unchecked MSR access error" on PEBS_ENABLE MSR.
- Patch 7/8: Prevent a theoretical kernel register data leak in sampling.
- Patch 8/8: Add kernel access check when kernel callchains are requested.

History:
v3: https://lore.kernel.org/all/[email protected]/
v2: https://lore.kernel.org/all/[email protected]/
v1: https://lore.kernel.org/all/[email protected]/

Dapeng Mi (8):
perf/x86/intel: Remove anythread_deprecated bit from perf_capabilities perf/x86/intel: Keep cap_user_rdpmc in sync with RDPMC user-disable
state
perf/x86/intel: Fallback to sw branch type decoding if no hw decoding perf/x86/intel: Fix kernel address leakages in LBR stack perf/x86/intel: Validate the return value of intel_pmu_init_hybrid() perf/x86/intel: Drop fixed-counter PEBS constraints for baseline PEBS perf/core: Fix kernel register info leak via hardware skid perf/core: Check kernel access when kernel callchains are requested

 arch/x86/events/core.c       |  3 +-
 arch/x86/events/intel/core.c | 60 +++++++++++++++++++++---------------
 arch/x86/events/intel/ds.c   | 13 --------
 arch/x86/events/intel/lbr.c  | 14 ++++++---
 arch/x86/events/perf_event.h |  4 +--
 kernel/events/core.c         | 41 +++++++++++++++++++-----
 6 files changed, 83 insertions(+), 52 deletions(-)

base-commit: 67d27727854def4a7e2b386429941f5c4741ccc4

Signature · 1 line
2.34.1