Skip to content

ipv6: mcast: annotate data races in /proc/net/igmp6

Yuyang Huang lkml netdev 2 versions – Applied

Status from this message: This series was applied to netdev/net-next.git (main)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 4 repliesApplied 2/2
  2. v12 patches 3 repliesSuperseded

Changes in v2 from the cover letter

- patch 2: read mca_flags before timer.expires to match write-side ordering and avoid printing a garbage timer value.

Patches in v2 All 2 applied

#Subject and filesSizeRepliesApplied
1/2ipv6: mcast: annotate data-races around mca_flagsnet/ipv6/mcast.c+32 -203 repliesApplied
2/2ipv6: mcast: annotate igmp6 timer expiry racenet/ipv6/mcast.c+2 -11 replyApplied

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchIdo Schimmel
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH net-next v2 0/2] ipv6: mcast: annotate data races in /proc/net/igmp6

/proc/net/igmp6 walks IPv6 multicast memberships under RCU without holding idev->mc_lock, taking a lockless snapshot of two fields that writers update under the lock: mca_flags and mca_work.timer.expires.

Patch 1 adds WRITE_ONCE() to all mca_flags update sites and READ_ONCE() to the procfs reader. Patch 2 does the same for the timer.expires read in the procfs path.

Changes in v2:
- patch 2: read mca_flags before timer.expires to match write-side ordering and avoid printing a garbage timer value.

Yuyang Huang (2):
ipv6: mcast: annotate data-races around mca_flags
ipv6: mcast: annotate igmp6 timer expiry race

 net/ipv6/mcast.c | 55 ++++++++++++++++++++++++++++++------------------
 1 file changed, 34 insertions(+), 21 deletions(-)
Signature · 1 line
2.43.0