Skip to content

drm/{i915, xe}: Refactor generic_handle_irq_safe() error messages

Jonathan Cavitt intel-gfx intel-xe 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5drm/xe/printk: Add xe_warn_once()drivers/gpu/drm/xe/xe_printk.h+3 -01 reply
2/5drm/xe/heci: Use xe print functions in xe_heci_gsc.cdrivers/gpu/drm/xe/xe_heci_gsc.c+10 -112 replies
3/5drm/xe/i2c: Use xe print functions in xe_i2c.cdrivers/gpu/drm/xe/xe_i2c.c+3 -30 replies
4/5drm/{i915, xe}: Refactor generic_handle_irq_safe() error messagesdrivers/gpu/drm/i915/display/intel_lpe_audio.c drivers/gpu/drm/i915/gt/intel_gsc.c drivers/gpu/drm/xe/xe_heci_gsc.c+4 -41 reply
5/5drm/xe/i2c: Report i2c irq handler issuedrivers/gpu/drm/xe/xe_i2c.c+4 -10 replies

Reviews trailers per patch

1 of 5 patches has a Reviewed-by or Acked-by.

PatchMichal Wajdeczko
1/5R-b
2/5
3/5
4/5
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/5] drm/{i915, xe}: Refactor generic_handle_irq_safe() error messages

Currently, all but one uses of generic_handle_irq_safe() report error messages using .*_err_ratelimited() error reporting helper functions. These helper functions declare their error messages in the following form:

"error handling [COMPONENT NAME] irq: %d\n"

.*_err_ratelimited() already logs "error" as a part of the error message, so declaring the error is redundant. Reword it.

The last usage of generic_handle_irq_safe() is in xe_i2c_irq_present(), and it currently lacks the same error reporting as in the other cases. This is not intentional, so put some logging there.

While we're here, we should also update the XE cases to use xe_err_ratelimited() instead of directly calling drm_err_ratelimited(). However, mixing drm error reporting functions with xe error reporting functions in the same file looks unprofessional, so update all drm error reporting functions in xe_heci_gsc.c and xe_i2c.c to use their xe counterparts.

This includes updating drm_warn_once() to use xe_warn_once() instead. Unfortunately, xe_warn_once() does not exist, so create it.

Jonathan Cavitt (5):
drm/xe/printk: Add xe_warn_once()
drm/xe/heci: Use xe print functions in xe_heci_gsc.c drm/xe/i2c: Use xe print functions in xe_i2c.c drm/{i915, xe}: Refactor generic_handle_irq_safe() error messages drm/xe/i2c: Report i2c irq handler issue

 .../gpu/drm/i915/display/intel_lpe_audio.c    |  2 +-
 drivers/gpu/drm/i915/gt/intel_gsc.c           |  2 +-
 drivers/gpu/drm/xe/xe_heci_gsc.c              | 21 +++++++++----------
 drivers/gpu/drm/xe/xe_i2c.c                   | 11 ++++++----
 drivers/gpu/drm/xe/xe_printk.h                |  3 +++
 5 files changed, 22 insertions(+), 17 deletions(-)
Signature · 1 line
2.53.0