Skip to content

mm/vmpressure: reduce CPU, memory and code overhead on cgroup v2

Usama Arif linux-mm lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 4 repliesIn review 1 of 2 applied
  2. v22 patches 11 repliesSuperseded
  3. v12 patches 10 repliesSuperseded

Patches in v3 1 of 2 applied

#Subject and filesSizeRepliesApplied
1/2mm/vmpressure: skip tree=true accounting on cgroup v2mm/vmpressure.c+6 -42 replies
2/2mm/vmpressure: move v1 userspace eventfd code into memcontrol-v1.cinclude/linux/vmpressure.h mm/memcontrol-v1.c mm/vmpressure.c+343 -2872 repliesApplied

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchShakeel ButtJohannes Weiner
1/2A-b A-b
2/2A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/2] mm/vmpressure: reduce CPU, memory and code overhead on cgroup v2

The vmpressure subsystem has two distinct consumers, gated by the @tree argument:

tree=false : in-kernel socket pressure, consumed by TCP/SCTP. This

               is cgroup v2 only; v1 sockets read memcg->tcpmem_pressure
               instead.

tree=true : cgroup v1 userspace eventfd notifications via the
memory.pressure_level / cgroup.event_control interface. v2 has no equivalent (userspace gets reclaim signals through memory.pressure / PSI, which doesn't touch vmpressure).

So of the four (hierarchy, tree) combinations, only two carry data that anyone reads. The existing early return in vmpressure() covered v1 + tree=false; the symmetric v2 + tree=true case was falling through and doing the full lock / accumulate / schedule_work / parent-walk dance, even though the events list it eventually iterates is empty on cgroup v2 (vmpressure_register_event() is wired up only through the v1 cftype "memory.pressure_level" and can't be reached from a v2 memcg).

Patch 1 extends the existing early return to also skip v2 + tree=true. On a v2-only host this eliminates a contended path where reclaimers can serialize on a single global sr_lock. bpftrace on a 176-core production host (cgroup v2, 285 memcgs, sustained reclaim) showed ~16,200 such calls per minute with tree = true.

Patch 2 follows up with a cleanup: it splits the v1 userspace eventfd interface (struct vmpressure_event, the events list and its mutex, the work_struct and its handler, the parent walk, vmpressure_register_event / unregister_event, and vmpressure_prio) into a new mm/memcontrol-v1.c built only when CONFIG_MEMCG_V1=y, behind small no-op stubs in the header. mm/vmpressure.c keeps the shared bits and the tree=false socket-pressure path. The size of vmpressure.c goes down to half and the code is much more simpler. The only #ifdef CONFIG_MEMCG_V1 remaining in source is around the v1-only fields inside struct vmpressure itself. Memory savings on CONFIG_MEMCG_V1=n:
struct vmpressure : 112B -> 24B
struct mem_cgroup : 1664B -> 1536B

This split is the first step toward eventually making vmpressure CONFIG_MEMCG_V1 only. The v2 in-kernel socket pressure path (tree=false) cannot be removed today immediately: PSI is not an
exact replacement for vmpressure, and switching networking socket-buffer back-off to PSI may regress networking performance or increase memory pressure in workloads that today rely on vmpressure's hysteresis. The medium-term plan is to introduce a PSI-based socket-pressure path, keep vmpressure available for v2 behind a defconfig as an opt-out for several releases, and only then drop the tree=false path entirely, at which point everything that remains in mm/memcontrol-v1.c is the whole subsystem.
---
v2 -> v3: https://lore.kernel.org/all/[email protected]/
- Move the cgroup v1 code into memcontrol-v1.c instead of creating a new file (Johannes)

v1 -> v2: https://lore.kernel.org/all/[email protected]/
- Add more in commit message about future plans of vmpressure for cgroup v2 (Shakeel)
- Remove unnecessary return statement in vmpressure for v1 only tree path (Michal)
- Rebased onto latest mm-new

Usama Arif (2):
mm/vmpressure: skip tree=true accounting on cgroup v2 mm/vmpressure: move v1 userspace eventfd code into memcontrol-v1.c

 include/linux/vmpressure.h |  46 +++++-
 mm/memcontrol-v1.c         | 292 +++++++++++++++++++++++++++++++++++
 mm/vmpressure.c            | 302 ++-----------------------------------
 3 files changed, 349 insertions(+), 291 deletions(-)
Signature · 1 line
2.53.0-Meta