smb: client: fix file compression flag ioctls
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest3 patches 0 repliesNew
- v13 patches 0 repliesSuperseded
Changes in v2 from the cover letter
- Patch 1 is unchanged.
- Patch 2 now requests FILE_READ_ATTRIBUTES for the temporary by-path handle, only falls back to by-path open for -EBADF from cifs_get_writable_file(), removes the thin set_compression wrapper, and moves the temporary cifsFileInfo off the stack to fix the LKP frame-size warning.
- Patch 3 now returns -EOPNOTSUPP for unsupported FS_IOC_SETFLAGS bits and is adjusted for the helper cleanup in patch 2.
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | smb/client: always return a value for FS_IOC_GETFLAGSfs/ | +5 | 0 replies | |
| 2/3 | smb/client: use writable handle for FS_IOC_SETFLAGS compressionfs/ | +112 | 0 replies | |
| 3/3 | smb/client: allow FS_IOC_SETFLAGS to clear compressionfs/ fs/ fs/ +5 more | +45 | 0 replies |
Reviews trailers per patch
All 3 patches have a Reviewed-by or Acked-by.
| Patch | ChenXiaoSong |
|---|---|
| 1/3 | R-b |
| 2/3 | R-b |
| 3/3 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 0/3] smb: client: fix file compression flag ioctls
From: Huiwen He <[email protected]>
v1->v2:
- Patch 1 is unchanged.
- Patch 2 now requests FILE_READ_ATTRIBUTES for the temporary by-path handle, only falls back to by-path open for -EBADF from cifs_get_writable_file(), removes the thin set_compression wrapper, and moves the temporary cifsFileInfo off the stack to fix the LKP frame-size warning.
- Patch 3 now returns -EOPNOTSUPP for unsupported FS_IOC_SETFLAGS bits and is adjusted for the helper cleanup in patch 2.
Link to v1:
https://lore.kernel.org/linux-cifs/[email protected]
Thanks,
Huiwen He
Huiwen He (3):
smb/client: always return a value for FS_IOC_GETFLAGS smb/client: use writable handle for FS_IOC_SETFLAGS compression smb/client: allow FS_IOC_SETFLAGS to clear compression
fs/smb/client/cifsglob.h | 2 +- fs/smb/client/cifssmb.c | 4 +- fs/smb/client/ioctl.c | 153 ++++++++++++++++++++++++++++++++++---- fs/smb/client/smb1ops.c | 5 +- fs/smb/client/smb1proto.h | 2 +- fs/smb/client/smb2ops.c | 4 +- fs/smb/client/smb2pdu.c | 6 +- fs/smb/client/smb2proto.h | 3 +- 8 files changed, 153 insertions(+), 26 deletions(-)
Signature · 1 line
2.43.0