Skip to content

smb: client: fix file compression flag ioctls

Huiwen He linux-cifs 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 0 repliesNew
  2. v13 patches 0 repliesSuperseded

Changes in v2 from the cover letter

- Patch 1 is unchanged.
- Patch 2 now requests FILE_READ_ATTRIBUTES for the temporary by-path handle, only falls back to by-path open for -EBADF from cifs_get_writable_file(), removes the thin set_compression wrapper, and moves the temporary cifsFileInfo off the stack to fix the LKP frame-size warning.
- Patch 3 now returns -EOPNOTSUPP for unsupported FS_IOC_SETFLAGS bits and is adjusted for the helper cleanup in patch 2.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3smb/client: always return a value for FS_IOC_GETFLAGSfs/smb/client/ioctl.c+5 -70 replies
2/3smb/client: use writable handle for FS_IOC_SETFLAGS compressionfs/smb/client/ioctl.c+112 -40 replies
3/3smb/client: allow FS_IOC_SETFLAGS to clear compressionfs/smb/client/cifsglob.h fs/smb/client/cifssmb.c fs/smb/client/ioctl.c +5 more+45 -240 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchChenXiaoSong
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/3] smb: client: fix file compression flag ioctls

From: Huiwen He <[email protected]>

v1->v2:
- Patch 1 is unchanged.
- Patch 2 now requests FILE_READ_ATTRIBUTES for the temporary by-path handle, only falls back to by-path open for -EBADF from cifs_get_writable_file(), removes the thin set_compression wrapper, and moves the temporary cifsFileInfo off the stack to fix the LKP frame-size warning.
- Patch 3 now returns -EOPNOTSUPP for unsupported FS_IOC_SETFLAGS bits and is adjusted for the helper cleanup in patch 2.

Link to v1:
https://lore.kernel.org/linux-cifs/[email protected]

Thanks,
Huiwen He

Huiwen He (3):
smb/client: always return a value for FS_IOC_GETFLAGS smb/client: use writable handle for FS_IOC_SETFLAGS compression smb/client: allow FS_IOC_SETFLAGS to clear compression

 fs/smb/client/cifsglob.h  |   2 +-
 fs/smb/client/cifssmb.c   |   4 +-
 fs/smb/client/ioctl.c     | 153 ++++++++++++++++++++++++++++++++++----
 fs/smb/client/smb1ops.c   |   5 +-
 fs/smb/client/smb1proto.h |   2 +-
 fs/smb/client/smb2ops.c   |   4 +-
 fs/smb/client/smb2pdu.c   |   6 +-
 fs/smb/client/smb2proto.h |   3 +-
 8 files changed, 153 insertions(+), 26 deletions(-)
Signature · 1 line
2.43.0