Skip to content

goldfish: Return error when device address is invalid

Kuan-Wei Chiu u-boot 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2timer: goldfish: Return error when device address is invaliddrivers/timer/goldfish_timer.c+4 -20 replies
2/2rtc: goldfish: Return error when device address is invaliddrivers/rtc/goldfish_rtc.c+6 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] goldfish: Return error when device address is invalid

A patch was submitted by Naveen for the goldfish serial driver to return an error immediately in of_to_plat() when dev_read_addr() fails, rather than deferring the failure to the probe() stage.

To maintain consistency across the goldfish driver family and better align with the driver model's fail fast design, this series applies the exact same logic to the goldfish timer and rtc drivers.

Inspired by Naveen's patch for the serial driver:
https://lore.kernel.org/u-boot/vgwnt6mnls3lf3zdm6mz5siztzkvppte4ykszbvifjzukvmksf@maaxe5agqpim/

Tested on qemu m68k virt board with date and sleep commands.

Kuan-Wei Chiu (2):
timer: goldfish: Return error when device address is invalid
rtc: goldfish: Return error when device address is invalid

 drivers/rtc/goldfish_rtc.c     | 8 ++++++--
 drivers/timer/goldfish_timer.c | 6 ++++--
 2 files changed, 10 insertions(+), 4 deletions(-)
Signature · 1 line
2.54.0.1032.g2f8565e1d1-goog