Test suite hardening, correctness fixes, and BPF optimization
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest52 patches 0 repliesNew
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/52 | stalld: Reject --force_fifo in single-threaded modesrc/ tests/ | +4 | 0 replies | |
| 2/52 | tests: Introduce test_section() helpertests/ tests/ tests/ +17 more | +124 | 0 replies | |
| 3/52 | tests: Introduce cleanup_scenario() helpertests/ tests/ tests/ +12 more | +71 | 0 replies | |
| 4/52 | tests: Introduce starvation and boost assertstests/ tests/ tests/ +4 more | +54 | 0 replies | |
| 5/52 | tests: Introduce find_starved_child() helpertests/ tests/ tests/ +4 more | +79 | 0 replies | |
| 6/52 | tests: Fix task exit timing in test_boost_restorationtests/ tests/ | +11 | 0 replies | |
| 7/52 | tests: Consolidate and adopt init_functional_test()tests/ tests/ tests/ +12 more | +64 | 0 replies | |
| 8/52 | tests: Introduce assert_stalld_rejects() helpertests/ tests/ tests/ +5 more | +33 | 0 replies | |
| 9/52 | tests: Fix boost verification in runtime and duration teststests/ tests/ | +24 | 0 replies | |
| 10/52 | tests: Fix subshell swallowing test resultstests/ | +15 | 0 replies | |
| 11/52 | tests: Fix repeated log match finding same linetests/ tests/ | +23 | 0 replies | |
| 12/52 | chore: Remove legacy test infrastructure and stale docs.claude/ .claude/ .claude/ +24 more | +12 | 0 replies | |
| 13/52 | tests: Add assertions to SCHED_OTHER restoration testtests/ | +32 | 0 replies | |
| 14/52 | tests: Fix CPU selection grep substring matchestests/ | +13 | 0 replies | |
| 15/52 | tests: Add idle CPU skipping assertiontests/ | +17 | 0 replies | |
| 16/52 | tests: Remove redundant pkill from cleanuptests/ | +0 | 0 replies | |
| 17/52 | tests: Introduce and adopt assert_log_contains() helpertests/ tests/ tests/ +8 more | +66 | 0 replies | |
| 18/52 | tests: Remove weak, redundant, and assertion-free test blockstests/ tests/ tests/ +7 more | +29 | 0 replies | |
| 19/52 | tests: Introduce and adopt assert_success() helpertests/ tests/ tests/ +7 more | +71 | 0 replies | |
| 20/52 | tests: Replace wait conditionals with assertstests/ tests/ tests/ +1 more | +10 | 0 replies | |
| 21/52 | tests: Remove if-wrappers around assert callstests/ tests/ tests/ +1 more | +29 | 0 replies | |
| 22/52 | tests: Abort immediately on test failuretests/ | +11 | 0 replies | |
| 23/52 | tests: Remove dead code after making fail() fataltests/ tests/ tests/ +13 more | +0 | 0 replies | |
| 24/52 | tests: Introduce and adopt process helperstests/ tests/ tests/ +1 more | +39 | 0 replies | |
| 25/52 | tests: Extract wait_for_process_exit helpertests/ | +42 | 0 replies | |
| 26/52 | tests: Reduce default wait timeoutstests/ tests/ | +7 | 0 replies | |
| 27/52 | tests: Reduce starvation_gen durationstests/ tests/ tests/ +5 more | +18 | 0 replies | |
| 28/52 | tests: Replace init sleeps in test_affinitytests/ | +12 | 0 replies | |
| 29/52 | tests: Drop redundant sleeps in test_pidfiletests/ | +0 | 0 replies | |
| 30/52 | tests: Remove redundant sleeps after start_stalldtests/ tests/ | +0 | 0 replies | |
| 31/52 | tests: Reduce timing and replace sleeps with event waitstests/ tests/ tests/ +4 more | +13 | 0 replies | |
| 32/52 | tests: Fix async-signal-unsafe handlertests/ | +1 | 0 replies | |
| 33/52 | bpf: Replace linear task scan with hash mapbpf/ src/ src/ | +131 | 0 replies | |
| 34/52 | stalld: fix data race on thread_runningsrc/ | +2 | 0 replies | |
| 35/52 | stalld: fix inverted DAEMON_UMASK valuesrc/ | +1 | 0 replies | |
| 36/52 | stalld: fix uninitialized buffer use in find_debugfs_mount_pointsrc/ | +4 | 0 replies | |
| 37/52 | stalld: fix buffer underflow in read_proc_statsrc/ | +2 | 0 replies | |
| 38/52 | stalld: fix buffer underflow in sched_debug_getsrc/ | +2 | 0 replies | |
| 39/52 | stalld: check pthread_create return in aggressive_mainsrc/ | +10 | 0 replies | |
| 40/52 | stalld: check pthread_create return in conservative_mainsrc/ | +5 | 0 replies | |
| 41/52 | stalld: fix signed integer overflow in set_reservationsrc/ src/ | +7 | 0 replies | |
| 42/52 | stalld: fix data race on config_buffer_sizesrc/ src/ | +2 | 0 replies | |
| 43/52 | stalld: remove async-signal-unsafe calls from signal handlersrc/ src/ src/ | +5 | 0 replies | |
| 44/52 | stalld: use CLOCK_MONOTONIC for starvation detectionsrc/ src/ src/ +1 more | +18 | 0 replies | |
| 45/52 | stalld: fix format string type mismatch for time_tsrc/ | +4 | 0 replies | |
| 46/52 | stalld: fix type mismatches in detect_task_formatsrc/ | +5 | 0 replies | |
| 47/52 | stalld: remove NULL deref in fill_waiting_task error handlersrc/ | +0 | 0 replies | |
| 48/52 | stalld: guard nextline() returns in sched_debug parsingsrc/ | +18 | 0 replies | |
| 49/52 | stalld: fix missing null-termination in is_runnablesrc/ | +2 | 0 replies | |
| 50/52 | stalld: fix snprintf truncation check in is_runnablesrc/ | +1 | 0 replies | |
| 51/52 | stalld: fix error return in queue_track_get_cpusrc/ | +1 | 0 replies | |
| 52/52 | stalld: fix format string type mismatch in set_cpu_affinitysrc/ | +1 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH stalld 00/52] Test suite hardening, correctness fixes, and BPF optimization
This series improves stalld reliability across three areas: the test infrastructure, the BPF backend, and the core daemon code.
The test suite is overhauled to eliminate false-passing tests and reduce runtime. An assertion framework replaces ad-hoc conditional checks, sleep-based synchronization gives way to event-driven waits, and helpers for common patterns like starvation detection and process lifecycle reduce boilerplate. Tests that silently swallowed failures in subshells or matched stale log lines are fixed. The cumulative effect is a suite that fails fast on real regressions and completes in a fraction of the previous wall-clock time.
The BPF queue_track backend replaces its per-CPU linear array with a hash map keyed by CPU and PID, turning the O(n) task lookup on every sched_wakeup into O(1). This eliminates a 2us latency penalty that consumed a significant portion of the 10us real-time budget on Telco workloads.
The remaining patches address a range of correctness issues in the
daemon: data races on shared variables are fixed with C11 atomics, buffer underflows and uninitialized buffer uses are guarded, the signal handler is made async-signal-safe, starvation timing is migrated from wall-clock time to CLOCK_MONOTONIC, format string mismatches and NULL pointer dereferences are corrected, pthread_create return values are checked, and a signed integer overflow in the SCHED_DEADLINE period calculation is resolved.
Wander Lairson Costa (52):
stalld: Reject --force_fifo in single-threaded mode
tests: Introduce test_section() helper
tests: Introduce cleanup_scenario() helper
tests: Introduce starvation and boost asserts
tests: Introduce find_starved_child() helper
tests: Fix task exit timing in test_boost_restoration
tests: Consolidate and adopt init_functional_test()
tests: Introduce assert_stalld_rejects() helper
tests: Fix boost verification in runtime and duration tests
tests: Fix subshell swallowing test results
tests: Fix repeated log match finding same line
chore: Remove legacy test infrastructure and stale docs
tests: Add assertions to SCHED_OTHER restoration test
tests: Fix CPU selection grep substring matches
tests: Add idle CPU skipping assertion
tests: Remove redundant pkill from cleanup
tests: Introduce and adopt assert_log_contains() helper
tests: Remove weak, redundant, and assertion-free test blocks
tests: Introduce and adopt assert_success() helper
tests: Replace wait conditionals with asserts
tests: Remove if-wrappers around assert calls
tests: Abort immediately on test failure
tests: Remove dead code after making fail() fatal
tests: Introduce and adopt process helpers
tests: Extract wait_for_process_exit helper
tests: Reduce default wait timeouts
tests: Reduce starvation_gen durations
tests: Replace init sleeps in test_affinity
tests: Drop redundant sleeps in test_pidfile
tests: Remove redundant sleeps after start_stalld
tests: Reduce timing and replace sleeps with event waits
tests: Fix async-signal-unsafe handler
bpf: Replace linear task scan with hash map
stalld: fix data race on thread_running
stalld: fix inverted DAEMON_UMASK value
stalld: fix uninitialized buffer use in find_debugfs_mount_point
stalld: fix buffer underflow in read_proc_stat
stalld: fix buffer underflow in sched_debug_get
stalld: check pthread_create return in aggressive_main
stalld: check pthread_create return in conservative_main
stalld: fix signed integer overflow in set_reservation
stalld: fix data race on config_buffer_size
stalld: remove async-signal-unsafe calls from signal handler
stalld: use CLOCK_MONOTONIC for starvation detection
stalld: fix format string type mismatch for time_t
stalld: fix type mismatches in detect_task_format
stalld: remove NULL deref in fill_waiting_task error handler
stalld: guard nextline() returns in sched_debug parsing
stalld: fix missing null-termination in is_runnable
stalld: fix snprintf truncation check in is_runnable
stalld: fix error return in queue_track_get_cpu
stalld: fix format string type mismatch in set_cpu_affinity
.claude/CLAUDE.md | 585 --------- .claude/agents/agent-prompt-engineer.md | 135 -- .claude/agents/c-expert.md | 53 - .claude/agents/code-reviewer.md | 104 -- .claude/agents/get-agent-hash | 99 -- .claude/agents/git-scm-master.md | 1154 ----------------- .claude/agents/kernel-hacker.md | 231 ---- .claude/agents/plan-validator.md | 130 -- .claude/agents/project-historian.md | 285 ---- .claude/agents/project-librarian.md | 604 --------- .claude/agents/project-manager.md | 388 ------ .claude/agents/project-scope-guardian.md | 326 ----- .claude/agents/python-expert.md | 57 - .claude/agents/test-specialist.md | 656 ---------- .claude/agents/update-agent-hashes | 96 -- .claude/context-snapshot.json | 103 -- .claude/rules | 42 - .gitignore | 5 +- bpf/stalld.bpf.c | 206 ++- src/queue_track.c | 99 +- src/queue_track.h | 107 +- src/sched_debug.c | 46 +- src/stalld.c | 51 +- src/stalld.h | 20 +- src/utils.c | 33 +- tests/BACKEND_USAGE.md | 269 ---- tests/CONTEXT_SNAPSHOT_2025-10-31.md | 231 ---- tests/Makefile | 29 +- tests/README.md | 29 +- tests/TODO.md | 727 ----------- tests/functional/test_affinity.sh | 178 +-- tests/functional/test_backend_selection.sh | 24 +- tests/functional/test_boost_duration.sh | 164 +-- tests/functional/test_boost_period.sh | 151 +-- tests/functional/test_boost_restoration.sh | 310 +---- tests/functional/test_boost_runtime.sh | 179 +-- tests/functional/test_cpu_selection.sh | 76 +- tests/functional/test_deadline_boosting.sh | 266 +--- tests/functional/test_fifo_boosting.sh | 269 +--- .../test_fifo_priority_starvation.sh | 197 +-- tests/functional/test_force_fifo.sh | 196 +-- tests/functional/test_foreground.sh | 65 +- tests/functional/test_idle_detection.sh | 195 +-- tests/functional/test_log_only.sh | 30 +- tests/functional/test_logging_destinations.sh | 38 +- tests/functional/test_pidfile.sh | 166 +-- tests/functional/test_runqueue_parsing.sh | 417 ------ tests/functional/test_starvation_detection.sh | 281 +--- tests/functional/test_starvation_threshold.sh | 138 +- tests/functional/test_task_merging.sh | 161 +-- tests/helpers/starvation_gen.c | 2 +- tests/helpers/test_helpers.sh | 356 +++-- tests/legacy/README.md | 169 --- tests/legacy/test01.c | 506 -------- tests/legacy/test01_wrapper.sh | 161 --- tests/run_tests.sh | 149 +-- 56 files changed, 964 insertions(+), 10780 deletions(-) delete mode 100644 .claude/CLAUDE.md delete mode 100644 .claude/agents/agent-prompt-engineer.md delete mode 100644 .claude/agents/c-expert.md delete mode 100644 .claude/agents/code-reviewer.md delete mode 100755 .claude/agents/get-agent-hash delete mode 100644 .claude/agents/git-scm-master.md delete mode 100644 .claude/agents/kernel-hacker.md delete mode 100644 .claude/agents/plan-validator.md delete mode 100644 .claude/agents/project-historian.md delete mode 100644 .claude/agents/project-librarian.md delete mode 100644 .claude/agents/project-manager.md delete mode 100644 .claude/agents/project-scope-guardian.md delete mode 100644 .claude/agents/python-expert.md delete mode 100644 .claude/agents/test-specialist.md delete mode 100755 .claude/agents/update-agent-hashes delete mode 100644 .claude/context-snapshot.json delete mode 100644 .claude/rules delete mode 100644 tests/BACKEND_USAGE.md delete mode 100644 tests/CONTEXT_SNAPSHOT_2025-10-31.md delete mode 100644 tests/TODO.md delete mode 100755 tests/functional/test_runqueue_parsing.sh delete mode 100644 tests/legacy/README.md delete mode 100644 tests/legacy/test01.c delete mode 100755 tests/legacy/test01_wrapper.sh
Signature · 1 line
2.54.0