net: pse-pd: add Realtek PSE MCU support
Status from this message: This series was applied to netdev/net-next.git (main)
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v14 Latest4 patches 3 repliesApplied 4/4
- v134 patches 0 repliesSuperseded
- v124 patches 4 repliesSuperseded
Earlier versions · 11
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v11 | 4 patches | 8 replies | Superseded | |
| v10 | 4 patches | 4 replies | Superseded | |
| v9 | 4 patches | 0 replies | Superseded | |
| v8 | 4 patches | 11 replies | Superseded | |
| v7 | 4 patches | 4 replies | Superseded | |
| v6 | 4 patches | 1 reply | Superseded | |
| v5 | 4 patches | 8 replies | Superseded | |
| v4 | 2 patches | 4 replies | Superseded | |
| v3 | 2 patches | 2 replies | Superseded | |
| v2 | 2 patches | 8 replies | Superseded | |
| v1 | 2 patches | 2 replies | Superseded |
Changes in v14 from the cover letter
- core: on a NOT_READY reply (MCU busy), resend the command a bounded
number of times before failing, instead of returning -EAGAIN at once
(matches the userspace realtek-poe behaviour); effectively UART-only,
as I2C absorbs NOT_READY in its poll. (Sashiko)
- core: reword the set_pw_limit comment - the value/type ordering isn't
atomic; document that a mid-sequence failure leaves the previous or
the requested cap, never a stale one (no read-modify-write added)
(Sashiko)
- header: reword the resp_is_final comment - seq_num rejects a stale
normal reply; the terminal error opcodes match unconditionally, since a
request the MCU couldn't parse carries no seq to correlate (Sashiko)
v13: https://lore.kernel.org/netdev/[email protected]/
Sashiko review: https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260811091218.353399-1-jelonek.jonas%40gmail.com
Patches in v14 All 4 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | dt-bindings: net: pse-pd: add bindings for Realtek PSE MCUDocumentation/ | +182 | 0 replies | Applied |
| 2/4 | net: pse-pd: add Realtek PSE MCU coreMAINTAINERS drivers/ drivers/ +2 more | +1106 | 0 replies | Applied |
| 3/4 | net: pse-pd: realtek-pse-mcu: add I2C transportdrivers/ drivers/ drivers/ | +160 | 0 replies | Applied |
| 4/4 | net: pse-pd: realtek-pse-mcu: add UART transportdrivers/ drivers/ drivers/ | +176 | 0 replies | Applied |
Reviews trailers per patch
3 of 4 patches have a Reviewed-by or Acked-by.
| Patch | Oleksij Rempel | Kory Maincent |
|---|---|---|
| 1/4 | R-b | R-b |
| 2/4 | ||
| 3/4 | R-b | |
| 4/4 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH net-next v14 0/4] net: pse-pd: add Realtek PSE MCU support
This series adds a PSE-PD driver for the microcontroller (MCU) that fronts the PSE silicon on a range of managed switches, together with its DT binding.
Hardware model
==============
These boards do not expose the PSE chips to the host directly. A small microcontroller sits on an I2C/SMBus or UART bus and manages one or more PSE chips behind it; the host CPU only ever talks to that MCU, using a fixed 12-byte request/response protocol with a trailing checksum. The PSE silicon never appears on the bus.
Two generations of the protocol exist, both Realtek's: an older one on boards with Broadcom PSE silicon (BCM59111, BCM59121) and a newer one used with Realtek's own PSE silicon (RTL8238B, RTL8239, RTL8239C). They diverge in opcode numbering and a few response layouts; the driver abstracts that behind a per-dialect opcode table and parser hooks, selected by the compatible. The specific PSE chip behind the MCU is detected at runtime and only influences per-chip constants (power scaling and the per-port cap).
The compatibles
===============
The protocol compatibles name two generations of the Realtek protocol, with the I2C framing folded in:
realtek,pse-mcu-gen1 gen1, UART realtek,pse-mcu-gen1-smbus gen1, I2C/SMBus realtek,pse-mcu-gen2 gen2, UART realtek,pse-mcu-gen2-smbus gen2, I2C/SMBus realtek,pse-mcu-gen2-i2c gen2, raw I2C
and each board carries a device-specific compatible that falls back to one of these, e.g.
compatible = "zyxel,xs1930-12hp-pse", "realtek,pse-mcu-gen2-smbus";
The naming is the part most likely to raise questions, so the reasoning up front (the binding documents it too):
- The node describes the MCU together with its Realtek firmware, not a PSE chip and not the microcontroller silicon. The PSE chips sit behind the MCU, never appear on the bus, and are reported by the MCU and detected at runtime; the microcontroller itself is a general-purpose part (GigaDevice, Nuvoton, ...) that varies across boards. What is fixed and Realtek's is the firmware and its host protocol - hence the 'realtek' prefix.
- gen1 and gen2 are two generations of that protocol, both Realtek's:
gen1 on older boards fronting Broadcom PSE silicon, gen2 the altered protocol used once Realtek shipped their own PSE silicon. The generation is fixed per board and is all the driver needs at DT-parse time, so the compatible encodes it.
- On I2C the MCU firmware expects one of two framings - SMBus or raw I2C - which is a genuine programming-model difference, so it is part of the compatible ('-smbus' / '-i2c'). A UART attachment carries no framing suffix; the transport is given structurally by the parent 'serial' node.
- Each board additionally carries a device-specific compatible that falls back to the protocol one. The driver only ever binds on the protocol compatible; the device-specific string keeps the binding specific and reserves a place for a future per-board quirk without having to retrofit device trees already deployed in the field.
Testing
=======
- Linksys LGS328MPCv2 (RTL8238B, I2C) - Zyxel GS1900-10HP A1 (BCM59121, UART) - Zyxel GS1900-10HP B1 (RTL8238B, UART) - Zyxel GS1920-24HPv2 (BCM59121, SMBus) - Zyxel XMG1915-10EP (RTL8239C, UART) - Zyxel XS1930-12HP (RTL8239, SMBus)
---
v13 -> v14:
- core: on a NOT_READY reply (MCU busy), resend the command a bounded
number of times before failing, instead of returning -EAGAIN at once
(matches the userspace realtek-poe behaviour); effectively UART-only,
as I2C absorbs NOT_READY in its poll. (Sashiko)
- core: reword the set_pw_limit comment - the value/type ordering isn't
atomic; document that a mid-sequence failure leaves the previous or
the requested cap, never a stale one (no read-modify-write added)
(Sashiko)
- header: reword the resp_is_final comment - seq_num rejects a stale
normal reply; the terminal error opcodes match unconditionally, since a
request the MCU couldn't parse carries no seq to correlate (Sashiko)
v13: https://lore.kernel.org/netdev/[email protected]/
Sashiko review: https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260811091218.353399-1-jelonek.jonas%40gmail.com
v12 -> v13:
- dt-bindings: added Reviewed-by from Kory
- core: clamp get_pw_limit/get_prio read-backs to the advertised max
(max_mW_per_port / pis_prio_max), matching what set + range enforce
(Sashiko)
- core: set_pw_limit programs the value before the user-mode switch, so
a failed value command keeps the port's previous cap (Sashiko)
- core: clarify disable-ports comment (also not re-gated on a later
probe error) (Sashiko)
- core: NOT adding Reviewed-by from Kory, again changes to the core
- i2c: added Reviewed-by from Kory
- uart: revert the recv non-final-frame loop back to a single wait — it
could drop a coalesced follow-up frame, issue that Sashiko raised
before hasn't been observed on real hardware; Kory's Reviewed-by
restored
v12: https://lore.kernel.org/netdev/[email protected]/
Sashiko review: https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260809112251.5797-1-jelonek.jonas%40gmail.com
v11 -> v12:
- all: dropped all Reviewed-by/Acked-by due to changes
- dt-bindings: AI review declined, no changes
- core: reserve seq_num 0 to avoid an all-zero garbage frame passing
as valid reply (Sashiko)
- core: reword disable-ports comment (Sashiko)
- i2c: drop DMA bounce buffer since the assumption about DMA behavior
was invalid (Sashiko)
- i2c: const-correct the SMBus send cast (Sashiko)
- i2c: reword commit message regarding DMA (Sashiko)
- uart: recv() waits past non-final frames (NOT_READY/stale) within
budget
v11: https://lore.kernel.org/netdev/[email protected]/
Sashiko review: https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260802100114.720594-1-jelonek.jonas%40gmail.com
v10 -> v11:
- patch 1: added Reviewed-by from Oleksij
- patch 2: added Acked-by from Oleksij
- rebase due to conflict in MAINTAINERS
v10: https://lore.kernel.org/netdev/[email protected]/
v9 -> v10:
- patch 2: fixed ordering in MAINTAINERS
- core: dropped unused fields, can be re-added later when actually
needed (Sashiko)
- core: harden frame desync for I2C by including seq_num in _is_final
helper (Sashiko)
- core: return constant voltage when MCU reports zero, in case the
port is not delivering. This avoids "Voltage null" errors in case a
power limit is set while port is not delivering (Sashiko)
- core: set_pw_limit: round up to avoid setting 0 in case the requested
limit is below 1 LSB (Sashiko)
- core: de-assert global port disable after MCU was discovered
successfully (Sashiko)
- core: fix and make more precise several comments (Sashiko)
v9: https://lore.kernel.org/all/[email protected]/
Sashiko review: https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260726112223.1286074-1-jelonek.jonas%40gmail.com
v8 -> v9:
- dt-bindings: renamed enable-gpios -> reset-gpios, verified on boards that the GPIO which is used with this is connected to the MCU's nRESET.
- dt-bindings: added disable-ports-gpios for GPIO that gates all ports (previously incorrectly assumed to be a rail gate, thus being wired via 'power-supply')
- dt-bindings: dropped 'power-supply', not used anymore and confusing, easy to confuse with PI's vpwr-supply (Sander)
- core: adjusted to match bindings, handling reset/disable-ports-gpio correctly and dropping 'power-supply' regulator stuff
- patch 1,2: dropped Reviewed-by/Acked-by tags due to changes.
- patch 3,4: added Reviewed-by from Kory
v8: https://lore.kernel.org/all/[email protected]/
v7 -> v8:
- dt-bindings: added Reviewed-by of Oleksij
- uart: check and warn-on-error for serdev_* operations (Oleksij)
- core, i2c, uart: added Acked-by of Oleksij
v7: https://lore.kernel.org/netdev/[email protected]/
v6 -> v7:
- dt-bindings: rename file to 'realtek,pse-mcu-gen1.yml', using specific compatible as file name (Conor)
- dt-bindings: added Conor's Reviewed-by
- core: replaced some leftover 'BCM/RTK' dialect framing in comments
- core: use rolling sequence number instead of always hardcoded 0xff, adressing the issue that stale data might be accepted for new requests (Sashiko)
- core: reordered MODULE_ calls to keep consistent across all driver parts
- i2c: replaced some leftover 'BCM/RTK' dialect framing in comments
- slight commit message adjustments
v6: https://lore.kernel.org/netdev/[email protected]/
v5 -> v6:
- dt-bindings: reworked the compatibles per DT-maintainer feedback
- name the two protocol generations -gen1 / -gen2 (both Realtek's) instead of the -rtk / -brcm dialect suffix (Conor)
- encode the I2C framing in the compatible (-smbus / raw -i2c) and drop the realtek,i2c-protocol property (Rob)
- add device-specific (switch) compatibles that fall back to the protocol compatibles, with the board↔protocol pairing enforced in the schema (Conor)
- rewrite the description accordingly
- driver: track the binding rework
- match on realtek,pse-mcu-gen{1,2}[-smbus|-i2c]; the I2C transport selects SMBus-vs-raw framing from a native_i2c match-data flag instead of reading the property (drops rtpse_mcu_needs_i2c_proto)
- rename the internal dialect and parser symbols rtk/brcm → gen1/gen2 (chip identifiers like RTL8238B/BCM59121 kept)
- i2c: DMA-safe raw-I2C path — bounce each frame through a heap buffer, since i2c_master_send()/i2c_master_recv() may DMA and the core's frame buffers are on the stack (SMBus and UART paths unaffected) (sashiko-nipa)
- includes: drop unused linux/mod_devicetable.h (core) (Uwe)
- includes: drop unused linux/delay.h (uart); add linux/regulator/consumer.h (core) and linux/slab.h + linux/string.h (i2c)
- commit messages — update the binding, core, and I2C messages to match (generations, framing-in-compatible, DMA note)
v5: https://lore.kernel.org/netdev/[email protected]/
v4 -> v5:
- split the single driver patch into three — core / I2C transport / UART transport. Binding stays patch 1, unchanged in shape. (Paolo) Please give guidance on how to if I should split more.
- core: set_pw_limit: guard divide-by-zero on pw_set_lsb_mW; cap the programmed value with U8_MAX instead of a bare 0xff; prg_val is now u8. (Oleksij, Sashiko)
- core: discover: also retry transient boot-time frames (-EBADMSG / -EBADE) within the bounded window, not just silence/NAK/not-ready (Sashiko).
- core: pw_status: report Broadcom 0x3 → TEST and 0x5 → OTHERFAULT (new STS_TEST/STS_OTHER_FAULT); pw_class comment corrected (0x3/0x5 aren't "other fault" on RTL; class-0-vs-fault note). (Sashiko)
- core: dropped unused decoded fields — function_mode, cls_type, disconnect_type, pair_type, inrush_mode, limit_type, chip_addr, channel. (Oleksij)
- core: removed forward declarations by moving the response structs above the dialect struct. (Oleksij)
- core: get_pw_limit_ranges: reverse-Christmas-tree local ordering. (Oleksij)
- core: dialect comment clarified (only divergent responses are hooked); commit message "parser hooks" tightened to "…for the responses that differ." (Sashiko)
- core: made parse_system_info hook void, both implementations return hardcoded 0. (Paolo)
- core: dropped GFP_KERNEL from kzalloc_obj. (Paolo)
- core: dropped unneeded u32 cast
- kept probe dev_info() for now deliberately, due to different opinions on whether a probe might print or not
- NOT included Acked-by from Oleksij, due to several changes
v4: https://lore.kernel.org/netdev/[email protected]/
v3 -> v4:
- move owner setting from core to transport, mitigating possible use-after-free (Sashiko)
- resend because net-next was still closed
v3: https://lore.kernel.org/netdev/[email protected]/
v2 -> v3:
- dt-bindings: using brcm instead of bcm for Broadcom
- rename the driver files and Kconfig symbols to realtek-pse-mcu-* / PSE_REALTEK_MCU* for consistency with the realtek,pse-mcu-* compatibles
- rename driver-internal prefix from 'rtpse_' to 'rtpse_mcu' to emphasize this targets the MCU-centric setup (and leaves room open for eventual directly addressable PSE chips)
- rework the vendor-prefix rationale (binding + commit message): the prefix names the protocol/firmware owner (Realtek documents the protocol and supplies the firmware), and -rtk/-brcm select the Realtek or Broadcom protocol dialect
- core: reject zeroed/echo-mismatched responses via the echoed seq_num (a BCM PORT_ENABLE on port 0 was otherwise accepted from an all-zero frame)
- core: enable the PoE supply before global-enabling the MCU, and roll back the global enable on probe failure or driver removal
- core: drop inline from helpers (flagged by automated check)
- uart: update the completion under rx_lock too, so a late frame can no longer make the next transaction fail spuriously with -EIO
v2: https://lore.kernel.org/netdev/[email protected]/
v1 -> v2:
- all points flagged by Sashiko addressed:
- uart: drop frame overflow (return count, not the stored length) so serdev retains no leftover bytes that would misalign the next response
- uart: guard rx_buf/rx_len with a spinlock to close a data race between the async receive_buf callback and send/recv
- i2c: return terminal MCU error opcodes (0xfd/0xfe) to the core immediately instead of polling to the 1 s timeout
- core: cap BCM59121 at 30 W (802.3at) — the basic 8-bit set command can't program the advertised 60 W (it silently clamped to 51 W)
v1: https://lore.kernel.org/netdev/[email protected]/
---
Jonas Jelonek (4):
dt-bindings: net: pse-pd: add bindings for Realtek PSE MCU
net: pse-pd: add Realtek PSE MCU core
net: pse-pd: realtek-pse-mcu: add I2C transport
net: pse-pd: realtek-pse-mcu: add UART transport
.../net/pse-pd/realtek,pse-mcu-gen1.yaml | 182 ++++ MAINTAINERS | 7 + drivers/net/pse-pd/Kconfig | 28 + drivers/net/pse-pd/Makefile | 3 + drivers/net/pse-pd/realtek-pse-mcu-core.c | 998 ++++++++++++++++++ drivers/net/pse-pd/realtek-pse-mcu-i2c.c | 148 +++ drivers/net/pse-pd/realtek-pse-mcu-uart.c | 164 +++ drivers/net/pse-pd/realtek-pse-mcu.h | 94 ++ 8 files changed, 1624 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/pse-pd/realtek,pse-mcu-gen1.yaml create mode 100644 drivers/net/pse-pd/realtek-pse-mcu-core.c create mode 100644 drivers/net/pse-pd/realtek-pse-mcu-i2c.c create mode 100644 drivers/net/pse-pd/realtek-pse-mcu-uart.c create mode 100644 drivers/net/pse-pd/realtek-pse-mcu.h
base-commit: 3da8c3c8b8fa99505624b65ef590482f48e766b6
Signature · 1 line
2.53.0