Skip to content

vsock/virtio: fix msg_iter desync on transmission failure

Octavian Purdila kvm linux-block linux-fsdevel lkml netdev virtualization 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 2 repliesIn review
  2. v22 patches 4 repliesSuperseded
  3. v11 patch 2 repliesSuperseded

Changes in v3 from the cover letter

- Use EXPORT_SYMBOL_GPL (Jens)

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2iov_iter: export iov_iter_restorelib/iov_iter.c+1 -02 replies
2/2vsock/virtio: restore msg_iter on transmission failurenet/vmw_vsock/virtio_transport_common.c+13 -00 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchStefano Garzarella
1/2A-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH net v3 0/2] vsock/virtio: fix msg_iter desync on transmission failure

This series fixes a msg_iter desync issue in the virtio vsock transport that can lead to warnings and eventual -ENOMEM under specific failure scenarios (e.g. partial GUP failure during MSG_ZEROCOPY transmission).

To fix this, we need to restore the msg_iter state on transmission failure. However, since virtio vsock transport can be built as a module, we first need to export iov_iter_restore.

Patch 1 exports iov_iter_restore.
Patch 2 implements the msg_iter restoration in virtio vsock.

Changes in v3:
- Use EXPORT_SYMBOL_GPL (Jens)

Changes in v2:
- Use iov_iter_savestate()/iov_iter_restore() (Stefano)
- Use a single restore point (Stefano)
- Reverse xmas tree (Stefano)
- Added comments in the code (Stefano)

v2: https://lore.kernel.org/all/[email protected]/
v1: https://lore.kernel.org/all/[email protected]/

Octavian Purdila (2):
iov_iter: export iov_iter_restore vsock/virtio: restore msg_iter on transmission failure

 lib/iov_iter.c                          |  1 +
 net/vmw_vsock/virtio_transport_common.c | 13 +++++++++++++
 2 files changed, 14 insertions(+)
Signature · 1 line
2.55.0.rc0.799.gd6f94ed593-goog