Skip to content

RFC samples/damon: handle damon_{start,stop}() failures

SeongJae Park damon linux-mm lkml stable 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 RFC Latest6 patches 2 repliesIn review
  2. v3 RFC4 patches 2 repliesSuperseded
  3. v2 RFC2 patches 3 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v1 RFC1 patch2 repliesSuperseded

Changes in v4 from the cover letter

- RFC v3: https://lore.kernel.org/[email protected]
- Add damon_Call() failure handling fixes for wsse and prcl. Changes from RFC v2
- RFC v2: https://lore.kernel.org/[email protected]
- Add damon_start() failure handling fixes for wsse and prcl. Changes from RFC v1
- RFC v1: https://lore.kernel.org/[email protected]
- Add damon_stop() failure handling fix to the series.

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6samples/damon/wsse: handle damon_start() failuresamples/damon/wsse.c+3 -10 replies
2/6samples/damon/prcl: handle damon_start() failuresamples/damon/prcl.c+3 -10 replies
3/6samples/damon/mtier: handle damon_start() failuresamples/damon/mtier.c+10 -10 replies
4/6samples/damon/mtier: handle damon_stop() failuresamples/damon/mtier.c+2 -10 replies
5/6samples/damon/wsse: stop and free damon ctx when damon_call() failssamples/damon/wsse.c+6 -10 replies
6/6samples/damon/prcl: stop and free damon ctx when damon_call() failssamples/damon/prcl.c+6 -10 replies

Reviews trailers per patch

None of the 6 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchZenghui Yu
SeriesR-b
1/6
2/6
3/6
4/6
5/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [RFC PATCH v4 0/6] samples/damon: handle damon_{start,stop}() failures

All DAMON sample modules are not correctly handling failures from damon_start(). Among those, mtier also has an additional problem for handling of damon_stop() failures. wsse and prcl also have a problem in their damon_call() failure handling. As a result, memory leaks, next DAMON operation disruptions, and use-after-free can happen. Fix those.

Note that only the damon_start() failure caused issues can reliably be reproduced. Reproducing those issues require the admin permission, though.

Changes from RFC v3
- RFC v3: https://lore.kernel.org/[email protected]
- Add damon_Call() failure handling fixes for wsse and prcl. Changes from RFC v2
- RFC v2: https://lore.kernel.org/[email protected]
- Add damon_start() failure handling fixes for wsse and prcl. Changes from RFC v1
- RFC v1: https://lore.kernel.org/[email protected]
- Add damon_stop() failure handling fix to the series.

SeongJae Park (6):
samples/damon/wsse: handle damon_start() failure samples/damon/prcl: handle damon_start() failure samples/damon/mtier: handle damon_start() failure samples/damon/mtier: handle damon_stop() failure samples/damon/wsse: stop and free damon ctx when damon_call() fails samples/damon/prcl: stop and free damon ctx when damon_call() fails

 samples/damon/mtier.c | 14 ++++++++++++--
 samples/damon/prcl.c  | 11 +++++++++--
 samples/damon/wsse.c  | 11 +++++++++--
 3 files changed, 30 insertions(+), 6 deletions(-)

base-commit: 1fe919b2e7b6455d0b976d75dcbe44324361a83b

Signature · 1 line
2.47.3