RFC samples/damon: handle damon_{start,stop}() failures
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 RFC Latest6 patches 2 repliesIn review
- v3 RFC4 patches 2 repliesSuperseded
- v2 RFC2 patches 3 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 RFC | 1 patch | 2 replies | Superseded |
Changes in v4 from the cover letter
- RFC v3: https://lore.kernel.org/[email protected]
- Add damon_Call() failure handling fixes for wsse and prcl. Changes from RFC v2
- RFC v2: https://lore.kernel.org/[email protected]
- Add damon_start() failure handling fixes for wsse and prcl. Changes from RFC v1
- RFC v1: https://lore.kernel.org/[email protected]
- Add damon_stop() failure handling fix to the series.
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | samples/damon/wsse: handle damon_start() failuresamples/ | +3 | 0 replies | |
| 2/6 | samples/damon/prcl: handle damon_start() failuresamples/ | +3 | 0 replies | |
| 3/6 | samples/damon/mtier: handle damon_start() failuresamples/ | +10 | 0 replies | |
| 4/6 | samples/damon/mtier: handle damon_stop() failuresamples/ | +2 | 0 replies | |
| 5/6 | samples/damon/wsse: stop and free damon ctx when damon_call() failssamples/ | +6 | 0 replies | |
| 6/6 | samples/damon/prcl: stop and free damon ctx when damon_call() failssamples/ | +6 | 0 replies |
Reviews trailers per patch
None of the 6 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Zenghui Yu |
|---|---|
| Series | R-b |
| 1/6 | |
| 2/6 | |
| 3/6 | |
| 4/6 | |
| 5/6 | |
| 6/6 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [RFC PATCH v4 0/6] samples/damon: handle damon_{start,stop}() failures
All DAMON sample modules are not correctly handling failures from damon_start(). Among those, mtier also has an additional problem for handling of damon_stop() failures. wsse and prcl also have a problem in their damon_call() failure handling. As a result, memory leaks, next DAMON operation disruptions, and use-after-free can happen. Fix those.
Note that only the damon_start() failure caused issues can reliably be reproduced. Reproducing those issues require the admin permission, though.
Changes from RFC v3
- RFC v3: https://lore.kernel.org/[email protected]
- Add damon_Call() failure handling fixes for wsse and prcl. Changes from RFC v2
- RFC v2: https://lore.kernel.org/[email protected]
- Add damon_start() failure handling fixes for wsse and prcl. Changes from RFC v1
- RFC v1: https://lore.kernel.org/[email protected]
- Add damon_stop() failure handling fix to the series.
SeongJae Park (6):
samples/damon/wsse: handle damon_start() failure samples/damon/prcl: handle damon_start() failure samples/damon/mtier: handle damon_start() failure samples/damon/mtier: handle damon_stop() failure samples/damon/wsse: stop and free damon ctx when damon_call() fails samples/damon/prcl: stop and free damon ctx when damon_call() fails
samples/damon/mtier.c | 14 ++++++++++++-- samples/damon/prcl.c | 11 +++++++++-- samples/damon/wsse.c | 11 +++++++++-- 3 files changed, 30 insertions(+), 6 deletions(-)
base-commit: 1fe919b2e7b6455d0b976d75dcbe44324361a83b
Signature · 1 line
2.47.3