Skip to content

rxrpc: Miscellaneous fixes

David Howells lkml netdev 1 version Applied

Status from this message: This series was applied to netdev/net.git (main)

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 1 replyApplied 5/5

Patches in v1 All 5 applied

#Subject and filesSizeRepliesApplied
1/5rxrpc: rxrpc_verify_data ensure rx_dec_buffer allocnet/rxrpc/recvmsg.c+1 -10 repliesApplied
2/5rxrpc: Don't move a peeked OOB message onto the pending queuenet/rxrpc/recvmsg.c+6 -50 repliesApplied
3/5rxrpc: Fix UAF in rxgk_issue_challenge()net/rxrpc/rxgk.c+2 -10 repliesApplied
4/5afs: Fix netns teardown to cancel the preallocation chargerfs/afs/rxrpc.c+4 -21 replyApplied
5/5rxrpc: serialize kernel accept preallocation with socket teardownnet/rxrpc/call_accept.c+19 -60 repliesApplied

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH net 0/5] rxrpc: Miscellaneous fixes

Here are some miscellaneous AF_RXRPC fixes:

(1) Make sure rxrpc_verify_data() allocates a buffer, even if the DATA packet being looked at is zero length to avoid potential NULL-pointer exceptions.

(2) Don't move an OOB message (e.g. an RxGK CHALLENGE) off the receive queue onto the pending queue in recvmsg() if MSG_PEEK is specified.

(3) Fix a potential UAF in rxgk_issue_challenge() in which a tracepoint refers to memory just freed by a different pointer.

(4) Fix afs net namespace teardown to cancel the incoming call preallocation charger before we disable listening (which will delete the preallocation queue).

(5) Fix rxrpc_kernel_charge_accept() to use the socket mutex to defend against listen(0)/shutdown simultaneously deleting the preallocation queue.

David

The patches can be found here also:

http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/log/?h=rxrpc-fixes

David Howells (2):
rxrpc: Fix UAF in rxgk_issue_challenge()
afs: Fix netns teardown to cancel the preallocation charger

Hyunwoo Kim (1):
rxrpc: Don't move a peeked OOB message onto the pending queue

Jeffrey Altman (1):
rxrpc: rxrpc_verify_data ensure rx_dec_buffer alloc

Li Daming (1):
rxrpc: serialize kernel accept preallocation with socket teardown

 fs/afs/rxrpc.c          |  6 ++++--
 net/rxrpc/call_accept.c | 25 +++++++++++++++++++------
 net/rxrpc/recvmsg.c     | 13 +++++++------
 net/rxrpc/rxgk.c        |  3 ++-
 4 files changed, 32 insertions(+), 15 deletions(-)