Skip to content

KVM: arm64: nv: Even more VNCR fixes

Oliver Upton kvmarm sashiko-reviews stable 4 versions – Applied

Status from this message: Applied to fixes, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest5 patches 3 repliesApplied
  2. v2 posting 2/25 patches 4 repliesSuperseded
  3. v2 posting 1/25 patches 0 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v12 patches0 repliesSuperseded

Changes in v3 from the cover letter

- Avoid evaluating permissions in case of early return / higher priority fault (Marc)
- Drop BUG_ON() from VNCR abort injetion path (Marc)
- Ensure is_gmem is always initialized (Sashiko)
- Return EINVAL for SEAs due to memory attribute mismatch, avoiding confusion with gmem memory fault exits (Sashiko)

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/5KVM: arm64: nv: Respect read-only PFN when mapping L1 VNCRarch/arm64/kvm/nested.c+26 -101 reply
2/5KVM: arm64: nv: Inject SEA if kvm_translate_vncr() can't resolve PFNarch/arm64/include/asm/kvm_nested.h arch/arm64/kvm/at.c arch/arm64/kvm/nested.c+14 -120 replies
3/5KVM: arm64: nv: Re-translate VNCR before injecting abortarch/arm64/kvm/nested.c+42 -691 reply
4/5KVM: arm64: nv: Inject SEA if guest VNCR isn't normal memoryarch/arm64/kvm/nested.c+11 -00 replies
5/5KVM: arm64: nv: Mark VM as bugged for unexpected VNCR abortarch/arm64/kvm/nested.c+2 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 0/5] KVM: arm64: nv: Even more VNCR fixes

Addressing most of the issues that came up with v2. Of note, I left Sashiko's (valid) feedback about HWPOISON PFNs not signalling userspace unaddressed because it requires untangling the return code mess a bit. That and the bugs fixed in this series are quite a bit worse :)

Applies to kvmarm/fixes.

v2 -> v3:
- Avoid evaluating permissions in case of early return / higher priority fault (Marc)
- Drop BUG_ON() from VNCR abort injetion path (Marc)
- Ensure is_gmem is always initialized (Sashiko)
- Return EINVAL for SEAs due to memory attribute mismatch, avoiding confusion with gmem memory fault exits (Sashiko)

Oliver Upton (5):
KVM: arm64: nv: Respect read-only PFN when mapping L1 VNCR
KVM: arm64: nv: Inject SEA if kvm_translate_vncr() can't resolve PFN
KVM: arm64: nv: Re-translate VNCR before injecting abort
KVM: arm64: nv: Inject SEA if guest VNCR isn't normal memory
KVM: arm64: nv: Mark VM as bugged for unexpected VNCR abort

 arch/arm64/include/asm/kvm_nested.h |   8 ++
 arch/arm64/kvm/at.c                 |   8 --
 arch/arm64/kvm/nested.c             | 164 ++++++++++++++--------------
 3 files changed, 91 insertions(+), 89 deletions(-)

base-commit: fcda30b134d262a1b1826555352bd7349051486e

Signature · 1 line
2.47.3