Skip to content

netdev: address a handful of nit picks

Jakub Kicinski netdev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 6 repliesIn review 2 of 3 applied
  2. v14 patches 15 repliesSuperseded

Patches in v2 2 of 3 applied

#Subject and filesSizeRepliesApplied
1/3netdev: correct error code in netdev_nl_queue_fill_lease()net/core/netdev-genl.c+1 -11 replyApplied
2/3netdev: avoid skipping objects on race with device disappearancenet/core/netdev-genl.c+17 -54 replies
3/3netdev: don't use dev->flags for IFF_UPnet/core/netdev-genl.c+1 -11 replyApplied

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchJoe DamatoDaniel BorkmannBobby EshlemanNikolay Aleksandrov
1/3R-b A-b R-b R-b
2/3A-b R-b R-b
3/3R-b A-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v2 thread

Cover letter [PATCH net-next v2 0/3] netdev: address a handful of nit picks

v1 of this has been sent back in June, it seems to have fallen thru the cracks.

I got slightly concerned about the state of the netdev-genl implementation after Gemini found the bug fixed by commit c849de7d8757 ("netdev: fix double-free in netdev_nl_bind_rx_doit()"). I fed the file into a couple of models to make sure we're not sitting on more bugs. The models haven't found anything worthy of a Fixes tag but some of the nit picks are borderline worth addressing.

v2: patch 1 (the only one with feedback) was sent separately
v1: https://lore.kernel.org/[email protected]

Jakub Kicinski (3):
netdev: correct error code in netdev_nl_queue_fill_lease()
netdev: avoid skipping objects on race with device disappearance
netdev: don't use dev->flags for IFF_UP

 net/core/netdev-genl.c | 26 +++++++++++++++++++-------
 1 file changed, 19 insertions(+), 7 deletions(-)
Signature · 1 line
2.55.0