Skip to content

drm/i915/scaler: allocation cleanup

Michał Grzelak intel-gfx intel-xe 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 2 repliesIn review
  2. v19 patches 5 repliesSuperseded

Changes in v2 from the cover letter

- drop obfuscation of CASF check (Ville, Nemesa)
- return proper error code (Jani)

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3drm/i915/scaler: remove unused plane_state argumentdrivers/gpu/drm/i915/display/skl_scaler.c+1 -21 reply
2/3drm/i915/scaler: s/i/scaler_id/ againdrivers/gpu/drm/i915/display/skl_scaler.c+6 -60 replies
3/3drm/i915/scaler: return -EINVAL instead of -1drivers/gpu/drm/i915/display/skl_scaler.c+2 -21 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchNemesa GargJani Nikula
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/3] drm/i915/scaler: allocation cleanup

Next version of [1]. Haven't came up with simpler CASF check than we currently have, thus to follow Ville's and Nemesa's remarks dropped the part of changing scaler allocation.
Also changed return value in case of failure of intel_allocate_scaler() & skl_pipe_scaler_get_hw_state(), as pointed out by Jani.

BR,
Michał

[1] https://lore.kernel.org/intel-gfx/[email protected]

---
Changelog:
v1->v2
- drop obfuscation of CASF check (Ville, Nemesa)
- return proper error code (Jani)

Michał Grzelak (3):
drm/i915/scaler: remove unused plane_state argument drm/i915/scaler: s/i/scaler_id/ again drm/i915/scaler: return -EINVAL instead of -1

 drivers/gpu/drm/i915/display/skl_scaler.c | 19 +++++++++----------
 1 file changed, 9 insertions(+), 10 deletions(-)
Signature · 1 line
2.45.2