Skip to content

FRMR pools fixes

Michael Gur linux-rdma 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest9 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9RDMA/mlx5: Fix mkey creation error flow rollbackdrivers/infiniband/hw/mlx5/mr.c+1 -10 replies
2/9RDMA/mlx5: Fix TPH extraction in FRMR pool keydrivers/infiniband/hw/mlx5/mr.c+9 -70 replies
3/9RDMA/core: Fix skipped usage for driver built FRMR keydrivers/infiniband/core/frmr_pools.c+1 -10 replies
4/9RDMA/core: Fix FRMR aging push to queue error flowdrivers/infiniband/core/frmr_pools.c+38 -150 replies
5/9RDMA/core: Fix FRMR set pinned push error pathdrivers/infiniband/core/frmr_pools.c+8 -31 reply
6/9RDMA/core: Avoid NULL dereference on FRMR bad usagedrivers/infiniband/core/frmr_pools.c+3 -10 replies
7/9RDMA/core: Fix FRMR handle leak on push failuredrivers/infiniband/core/frmr_pools.c drivers/infiniband/hw/mlx5/mr.c include/rdma/frmr_pools.h+15 -110 replies
8/9RDMA/core: Add ib_frmr_pool_drop for unrecoverable handlesdrivers/infiniband/core/frmr_pools.c include/rdma/frmr_pools.h+16 -00 replies
9/9RDMA/mlx5: Drop FRMR pool handle on UMR revoke failuredrivers/infiniband/hw/mlx5/mr.c+9 -30 replies

Reviews trailers per patch

1 of 9 patches has a Reviewed-by or Acked-by.

PatchTao Cui
1/9
2/9
3/9
4/9
5/9R-b
6/9
7/9
8/9
9/9

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH rdma-next 0/9] FRMR pools fixes

From: Michael Guralnik <[email protected]>

This series addresses several bugs in FRMR pool handling.

Patch 2 fixes incorrect masking of TPH-related bits in the FRMR pool key, which caused stale TPH values to be used when creating handles from an empty pool.

Patch 3 fixes set-pinned flow to use the pool key returned from the driver build_key callback instead of the raw key supplied by user.

Patch 8 extends the FRMR pools API with a new drop() operation. This allows drivers to update pool state on handle destruction when revocation fails, without incorrectly returning the handle to the pool.

The remaining patches fix error path handling, covering cases where memory allocation fails during queue expansion, and where handle creation or destruction operations return errors.

Michael Guralnik (9):
RDMA/mlx5: Fix mkey creation error flow rollback RDMA/mlx5: Fix TPH extraction in FRMR pool key RDMA/core: Fix skipped usage for driver built FRMR key RDMA/core: Fix FRMR aging push to queue error flow RDMA/core: Fix FRMR set pinned push error path RDMA/core: Avoid NULL dereference on FRMR bad usage RDMA/core: Fix FRMR handle leak on push failure RDMA/core: Add ib_frmr_pool_drop for unrecoverable handles RDMA/mlx5: Drop FRMR pool handle on UMR revoke failure

 drivers/infiniband/core/frmr_pools.c | 104 +++++++++++++++++++--------
 drivers/infiniband/hw/mlx5/mr.c      |  31 +++++---
 include/rdma/frmr_pools.h            |   3 +-
 3 files changed, 98 insertions(+), 40 deletions(-)
Signature · 1 line
2.52.0