ARM: mstar: fix two device_node refcount leaks in mstarv7.c
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest2 patches 1 replyIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | ARM: mstar: fix device_node refcount leak in mstarv7_boot_secondary()arch/ | +1 | 0 replies | |
| 2/2 | ARM: mstar: fix device_node refcount leak in mstarv7_init()arch/ | +1 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/2] ARM: mstar: fix two device_node refcount leaks in mstarv7.c
mstarv7.c leaks the device_node reference taken by of_find_compatible_node() in two __init paths: mstarv7_boot_secondary() (the "mstar,smpctrl" node) and mstarv7_init() (the "mstar,l3bridge" node). of_iomap() does not take ownership of the node, so each is a one-shot device_node refcount leak per boot.
The two leaks were introduced by different commits, so they are split into one patch each. Both drop the reference right after of_iomap().
Found by static analysis tool CodeQL. The series is build-tested only (arm, multi_v7_defconfig + CONFIG_ARCH_MSTARV7); I have no mstar hardware, so runtime testing would be appreciated.
Weigang He (2):
ARM: mstar: fix device_node refcount leak in mstarv7_boot_secondary()
ARM: mstar: fix device_node refcount leak in mstarv7_init()
arch/arm/mach-mstar/mstarv7.c | 2 ++ 1 file changed, 2 insertions(+)
base-commit: 0f61b1860cc3f52aef9036d7235ed1f017632193
Signature · 1 line
2.43.0