Skip to content

drm/amd/pm: smu_v14_0_0: DPM clock fixes for Strix Halo

Priya Hosur amd-gfx 7 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest posting 2/24 patches 1 replyIn review
  2. v5 posting 1/24 patches 0 repliesSuperseded
  3. v44 patches 1 replySuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v34 patches3 repliesSuperseded
v2 posting 2/20 of 4 patches0 repliesSuperseded
v2 posting 1/24 patches2 repliesSuperseded
v14 patches6 repliesSuperseded

Changes in v5 from the cover letter

- Extract smu_v14_0_0_find_clk_level() helper used by both DCLK metric lookup (patch 1) and emit_clk_levels (patch 4) per Lijo's review feedback on v4

Patches in v5 posting 2/2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4drm/amd/pm: smu_v14_0_0: fix DCLK metric reporting via VCLK level indexdrivers/gpu/drm/amd/pm/swsmu/smu14/smu_v14_0_0_ppt.c+52 -01 reply
2/4drm/amd/pm: add IP_VERSION(11, 5, 1) to vclk/dclk DPM sysfs whitelistsdrivers/gpu/drm/amd/pm/amdgpu_pm.c+6 -20 replies
2/4drm/amd/pm: add IP_VERSION(11, 5, 1) to vclk/dclk DPM sysfs whitelistsdrivers/gpu/drm/amd/pm/amdgpu_pm.c+6 -20 replies
2/4drm/amd/pm: add IP_VERSION(11, 5, 1) to vclk/dclk DPM sysfs whitelistsdrivers/gpu/drm/amd/pm/amdgpu_pm.c+6 -20 replies
3/4drm/amd/pm: smu_v14_0_0: add SMU_DCEFCLK support in DPM frequency queriesdrivers/gpu/drm/amd/pm/swsmu/smu14/smu_v14_0_0_ppt.c+28 -00 replies
3/4drm/amd/pm: smu_v14_0_0: add SMU_DCEFCLK support in DPM frequency queriesdrivers/gpu/drm/amd/pm/swsmu/smu14/smu_v14_0_0_ppt.c+28 -00 replies
4/4drm/amd/pm: smu_v14_0_0: use find_clk_level() for DPM level markingdrivers/gpu/drm/amd/pm/swsmu/smu14/smu_v14_0_0_ppt.c+22 -70 replies
4/4drm/amd/pm: smu_v14_0_0: use find_clk_level() for DPM level markingdrivers/gpu/drm/amd/pm/swsmu/smu14/smu_v14_0_0_ppt.c+22 -70 replies

Reviews trailers per patch

3 of 8 patches have a Reviewed-by or Acked-by.

PatchLijo LazarAlex Deucher
1/4A-b
2/4
2/4
2/4
3/4
3/4
4/4R-b R-b
4/4R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 0/4] drm/amd/pm: smu_v14_0_0: DPM clock fixes for Strix Halo

This series fixes DPM clock reporting issues on SMU v14.0.x APUs (Strix Halo / GC 11.5.x / SMU 14.0.1):

1. Introduce smu_v14_0_0_find_clk_level() helper and fix DCLK metric reporting by looking up the VCLK DPM level index
2. Expose vclk/dclk DPM sysfs entries for IP_VERSION(11,5,1)
3. Add SMU_DCEFCLK support in DPM frequency queries
4. Use the shared helper in emit_clk_levels for closest-match DPM level marking

v5:
- Extract smu_v14_0_0_find_clk_level() helper used by both DCLK metric lookup (patch 1) and emit_clk_levels (patch 4) per Lijo's review feedback on v4

v4:
- Drop early-break optimisation (Lijo)
- Drop explicit count guard; rely on for-loop (Lijo)
- Add Reviewed-by: Lijo Lazar on patch 4

v3:
- Add closest-match DPM fallback (patch 4) for MCLK/FCLK marker
- Reverse DPM index for SMU_MCLK
- Add SMU_DCEFCLK support (patch 3)

v2:
- Split IP_VERSION(11,5,1) whitelists to a separate patch

Priya Hosur (4):
drm/amd/pm: smu_v14_0_0: fix DCLK metric reporting via VCLK level
index
drm/amd/pm: add IP_VERSION(11,5,1) to vclk/dclk DPM sysfs whitelists drm/amd/pm: smu_v14_0_0: add SMU_DCEFCLK support in DPM frequency
queries
drm/amd/pm: smu_v14_0_0: use find_clk_level() for DPM level marking

 drivers/gpu/drm/amd/pm/amdgpu_pm.c            |   8 +-
 .../drm/amd/pm/swsmu/smu14/smu_v14_0_0_ppt.c  | 105 +++++++++++++++++-
 2 files changed, 106 insertions(+), 7 deletions(-)
Signature · 1 line
2.43.0