Skip to content

drm/i915/cdclk: cdclk pcode related fixes and refactoring

Ville Syrjala intel-gfx intel-xe 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest14 patches 0 repliesNew
  2. v114 patches 17 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14drm/i915/cdclk: Don't bail if pcode post nofify failsdrivers/gpu/drm/i915/display/intel_cdclk.c+1 -30 replies
2/14drm/i915/cdclk: Pass CDCLK in MHz to pcode on DG2drivers/gpu/drm/i915/display/intel_cdclk.c+17 -80 replies
3/14drm/i915/cdclk: Do the DG2 CDCLK/pipe power well notify properlydrivers/gpu/drm/i915/display/intel_cdclk.c+6 -60 replies
4/14drm/i915/cdclk: Notify DG2 pcode about pipe power wells regardless of CDCLKdrivers/gpu/drm/i915/display/intel_cdclk.c+6 -20 replies
5/14drm/i915/cdclk: Stop forcing voltage level to 3 all the time on DG2drivers/gpu/drm/i915/display/intel_cdclk.c+0 -10 replies
6/14drm/i915/cdclk: Drop pointless platform check from bxt_set_cdclk()drivers/gpu/drm/i915/display/intel_cdclk.c+5 -60 replies
7/14drm/i915/dg2: s/intel_/dg2_/ for DG2 specific stuffdrivers/gpu/drm/i915/display/intel_cdclk.c+14 -170 replies
8/14drm/i915/cdclk: Unify the pcode pre/post notify in bxt_set_cdclk()drivers/gpu/drm/i915/display/intel_cdclk.c+6 -100 replies
9/14drm/i915/cdclk: Unify pcode related debugsdrivers/gpu/drm/i915/display/intel_cdclk.c+36 -290 replies
10/14drm/i915/cdclk: Extract bdw_cdclk_pcode_{pre, post}_notify()drivers/gpu/drm/i915/display/intel_cdclk.c+15 -30 replies
11/14drm/i915/cdclk: Extract skl_cdclk_pcode_{pre, post}_notify()drivers/gpu/drm/i915/display/intel_cdclk.c+19 -130 replies
12/14drm/i915/cdclk: Extract bxt_cdclk_pcode_{pre, post}_notify()drivers/gpu/drm/i915/display/intel_cdclk.c+26 -160 replies
13/14drm/i915/cdclk: Introduce CDCLK .{pre, post}_notify() vfuncsdrivers/gpu/drm/i915/display/intel_cdclk.c+73 -490 replies
14/14drm/i915/cdclk: Hoist intel_cdclk_{pre, post}_notify() calls upwardsdrivers/gpu/drm/i915/display/intel_cdclk.c+9 -240 replies

Reviews trailers per patch

All 14 patches have a Reviewed-by or Acked-by.

PatchJani Nikula
1/14R-b
2/14R-b
3/14R-b
4/14R-b
5/14R-b
6/14R-b
7/14R-b
8/14R-b
9/14R-b
10/14R-b
11/14R-b
12/14R-b
13/14R-b
14/14R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/14] drm/i915/cdclk: cdclk pcode related fixes and refactoring

From: Ville Syrjälä <[email protected]>

Fix up some bugs around the cdclk pcode notificatiosn on DG2, follow up with some unification/cleanups, and finally convert the pcode stuff (except on dg2, due to it doing weird things) into vfuncs (goal being to make the code less messy).

v2: s/cdclk/cdclk_mhz/ in the dg2 code

Ville Syrjälä (14):
drm/i915/cdclk: Don't bail if pcode post nofify fails drm/i915/cdclk: Pass CDCLK in MHz to pcode on DG2 drm/i915/cdclk: Do the DG2 CDCLK/pipe power well notify properly drm/i915/cdclk: Notify DG2 pcode about pipe power wells regardless of
CDCLK
drm/i915/cdclk: Stop forcing voltage level to 3 all the time on DG2 drm/i915/cdclk: Drop pointless platform check from bxt_set_cdclk() drm/i915/dg2: s/intel_/dg2_/ for DG2 specific stuff drm/i915/cdclk: Unify the pcode pre/post notify in bxt_set_cdclk() drm/i915/cdclk: Unify pcode related debugs
drm/i915/cdclk: Extract bdw_cdclk_pcode_{pre,post}_notify() drm/i915/cdclk: Extract skl_cdclk_pcode_{pre,post}_notify() drm/i915/cdclk: Extract bxt_cdclk_pcode_{pre,post}_notify() drm/i915/cdclk: Introduce CDCLK .{pre,post}_notify() vfuncs drm/i915/cdclk: Hoist intel_cdclk_{pre,post}_notify() calls upwards

 drivers/gpu/drm/i915/display/intel_cdclk.c | 314 ++++++++++++---------
 1 file changed, 180 insertions(+), 134 deletions(-)
Signature · 1 line
2.54.0