Skip to content

Enable per exec queue MSI-X vector assignment

Stuart Summers intel-xe 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest11 patches 9 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11drm/xe: Add kerneldoc to xe_wait_user_fence_ioctl()drivers/gpu/drm/xe/xe_wait_user_fence.c+22 -00 replies
2/11drm/xe: Handle NULL in xe_exec_queue_get_unless_zero()drivers/gpu/drm/xe/xe_exec_queue.h+1 -10 replies
3/11drm/xe: Cap MSI-X vector count to XE_MSIX_MAX_VECSdrivers/gpu/drm/xe/xe_irq.c drivers/gpu/drm/xe/xe_irq.h+8 -14 replies
4/11drm/xe: Assign dedicated MSI-X vectors to exec queuesdrivers/gpu/drm/xe/xe_device_types.h drivers/gpu/drm/xe/xe_exec_queue.c drivers/gpu/drm/xe/xe_irq.c +1 more+65 -30 replies
5/11drm/xe: Add configfs max_msix_vecs attributedrivers/gpu/drm/xe/xe_configfs.c drivers/gpu/drm/xe/xe_configfs.h drivers/gpu/drm/xe/xe_irq.c+81 -10 replies
6/11drm/xe: Remove memirq status and source checks for engine interruptsdrivers/gpu/drm/xe/xe_memirq.c+10 -260 replies
7/11drm/xe: Add per-exec-queue user fence wait queuedrivers/gpu/drm/xe/xe_exec_queue.c drivers/gpu/drm/xe/xe_exec_queue_types.h drivers/gpu/drm/xe/xe_guc_submit.c +7 more+35 -112 replies
8/11drm/xe: Track all exec queues in a device-level ufence listdrivers/gpu/drm/xe/xe_device.c drivers/gpu/drm/xe/xe_device_types.h drivers/gpu/drm/xe/xe_exec_queue.c +1 more+27 -00 replies
9/11drm/xe: Hook up per queue thread wake to the unique MSI-X vector allocationdrivers/gpu/drm/xe/xe_irq.c drivers/gpu/drm/xe/xe_memirq.c drivers/gpu/drm/xe/xe_memirq.h+14 -70 replies
10/11drm/xe: Enable per-queue ufence wake in ioctl and wake functiondrivers/gpu/drm/xe/xe_wait_user_fence.c+34 -100 replies
11/11drm/xe/memirq: Enable compute walker post-sync interruptdrivers/gpu/drm/xe/regs/xe_lrc_layout.h drivers/gpu/drm/xe/xe_lrc.c drivers/gpu/drm/xe/xe_memirq.c+26 -40 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/11] Enable per exec queue MSI-X vector assignment

This series adds support for per exec queue MSI-X vector assignment as well as a per exec queue wait queue in the wait user fence ioctl. MSI-X vectors are dynamically assigned during exec queue creation up to a set maximum. Once the max is reached, everything else falls back to the default vector.

These dynamic vectors allow us to wake up a targeted wait queue and user thread instead of broadcasting out to all potential user threads like we're doing today. This is interesting when we have many user threads outstanding as we don't want to wake them up in a storm for each interrupt coming in.

Additionally, there have been changes in the memirq code lately to isolate some of the interrupts handled here. Starting with xe3p, however, we have new interrupts available for compute walker post sync interrupts. Currently these are enabled for legacy MSI use cases, but the bits are also available for MSI-X. Enable those bits here.

v2: Drop the drm_dbg change patch
Directly call xe_hw_engine_handle_irq() from xe_memirq_hwe_handler() Only add to ufence_list for user queues

Stuart Summers (11):
drm/xe: Add kerneldoc to xe_wait_user_fence_ioctl() drm/xe: Handle NULL in xe_exec_queue_get_unless_zero() drm/xe: Cap MSI-X vector count to XE_MSIX_MAX_VECS drm/xe: Assign dedicated MSI-X vectors to exec queues drm/xe: Add configfs max_msix_vecs attribute
drm/xe: Remove memirq status and source checks for engine interrupts drm/xe: Add per-exec-queue user fence wait queue
drm/xe: Track all exec queues in a device-level ufence list drm/xe: Hook up per queue thread wake to the unique MSI-X vector
allocation
drm/xe: Enable per-queue ufence wake in ioctl and wake function drm/xe/memirq: Enable compute walker post-sync interrupt

 drivers/gpu/drm/xe/regs/xe_lrc_layout.h  |  3 +
 drivers/gpu/drm/xe/xe_configfs.c         | 71 ++++++++++++++++++++++++
 drivers/gpu/drm/xe/xe_configfs.h         |  6 ++
 drivers/gpu/drm/xe/xe_device.c           |  2 +
 drivers/gpu/drm/xe/xe_device_types.h     | 11 ++++
 drivers/gpu/drm/xe/xe_exec_queue.c       | 51 ++++++++++++++++-
 drivers/gpu/drm/xe/xe_exec_queue.h       |  2 +-
 drivers/gpu/drm/xe/xe_exec_queue_types.h |  6 ++
 drivers/gpu/drm/xe/xe_guc_submit.c       |  6 +-
 drivers/gpu/drm/xe/xe_hw_engine.c        |  6 +-
 drivers/gpu/drm/xe/xe_hw_engine.h        |  3 +-
 drivers/gpu/drm/xe/xe_irq.c              | 36 ++++++++++--
 drivers/gpu/drm/xe/xe_irq.h              |  9 +++
 drivers/gpu/drm/xe/xe_lrc.c              | 15 ++++-
 drivers/gpu/drm/xe/xe_memirq.c           | 59 +++++++++-----------
 drivers/gpu/drm/xe/xe_memirq.h           |  4 +-
 drivers/gpu/drm/xe/xe_sync.c             |  3 +-
 drivers/gpu/drm/xe/xe_wait_user_fence.c  | 64 ++++++++++++++++++++-
 drivers/gpu/drm/xe/xe_wait_user_fence.h  |  4 ++
 19 files changed, 310 insertions(+), 51 deletions(-)
Signature · 1 line
2.43.0