Skip to content

xen/scsiback: fix command-tag handling on pre-completion error paths

Michael Bommarito linux-scsi lkml sashiko-reviews stable xen-devel 1 version Applied

Status from this message: Applied to 7.2/scsi-staging, thanks!

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 4 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/2xen/scsiback: free unsubmitted command instead of double-putting itdrivers/xen/xen-scsiback.c+22 -61 reply
2/2xen/scsiback: free the command tag on the TMR submit-failure pathdrivers/xen/xen-scsiback.c+1 -12 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchJuergen Gross
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] xen/scsiback: fix command-tag handling on pre-completion error paths

scsiback_get_pend_req() hands a pvSCSI frontend request a session tag and a zeroed se_cmd. Two error paths that run before the command completes through the target core mishandle that command and leak (or, in one case, underflow) the tag.

Impact: a pvSCSI guest can exhaust a LUN's per-session command tag pool, stopping the LUN, via crafted ring requests; for the first case the refcount underflow also panics the host under panic_on_warn.

Patch 1 fixes scsiback_do_cmd_fn(): on a failed grant map and on an unknown request type the never-initialised command (cmd_kref == 0) is freed with transport_generic_free_cmd(), which underflows the zero refcount and leaks the tag.

Patch 2 fixes scsiback_device_action(): when target_submit_tmr() fails the
err: path frees nothing. transport_generic_free_cmd() cannot be used there either, since the command is initialised by then and se_tmr_req has already been freed on one error sub-path.

Both paths go through one helper that returns just the tag.

Patch 1's underflow was reproduced on a Xen dom0 (guest to host, with a panic_on_warn host panic); with the series applied the same request is handled with no underflow.

Michael Bommarito (2):
xen/scsiback: free unsubmitted command instead of double-putting it xen/scsiback: free the command tag on the TMR submit-failure path

 drivers/xen/xen-scsiback.c | 30 +++++++++++++++++++++++-------
 1 file changed, 23 insertions(+), 7 deletions(-)

base-commit: 5200f5f493f79f14bbdc349e402a40dfb32f23c8

Signature · 1 line
2.53.0