Skip to content

system: Clarify legacy physical_memory_read/write/map/unmap API

Philippe Mathieu-Daudé qemu-devel 2 versions – Applied

Status from this message: Queued, thanks.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest6 patches 3 repliesApplied
  2. v16 patches 7 repliesSuperseded

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/6system: Document cpu_physical_memory_*() declarationsdocs/devel/loads-stores.rst include/exec/cpu-common.h+47 -40 replies
2/6accel/kvm: Replace legacy cpu_physical_memory_write() callaccel/kvm/kvm-all.c+4 -82 replies
3/6gdbstub/system: Replace legacy cpu_physical_memory_read/write() callsgdbstub/system.c+5 -60 replies
4/6target/s390x: Factor common s390_ipl_read/write() helperstarget/s390x/diag.c+23 -180 replies
5/6target/s390x: Replace legacy cpu_physical_memory_read/write() callstarget/s390x/diag.c+4 -20 replies
6/6system: Move cpu_physical_memory_*() declarations to 'system/physmem.h'docs/devel/loads-stores.rst dump/dump.c dump/win_dump-x86.c +51 more+270 -2290 replies

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchRichard HendersonManos Pitsidianakis
1/6R-b
2/6R-b R-b
3/6R-b
4/6R-b
5/6R-b
6/6R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/6] system: Clarify legacy physical_memory_read/write/map/unmap API

Missing review: #2

It is not obvious the cpu_physical_memory_read/write/map/unmap() methods do not involve vCPU at all and use the legacy global address space. Document that, because this is an issue for some board which doesn't use it at all. Rename the methods stripping the 'cpu_' prefix.

Clean a pair of dubious uses out of hw/.

Based-on: <[email protected]>

Philippe Mathieu-Daudé (6):
system: Document cpu_physical_memory_*() declarations accel/kvm: Replace legacy cpu_physical_memory_write() call gdbstub/system: Replace legacy cpu_physical_memory_read/write() calls target/s390x: Factor common s390_ipl_read/write() helpers target/s390x: Replace legacy cpu_physical_memory_read/write() calls
system: Move cpu_physical_memory_*() declarations to
'system/physmem.h'

 docs/devel/loads-stores.rst            | 18 +++++-----
 scripts/coccinelle/exec_rw_const.cocci | 16 ++++-----
 hw/xtensa/bootparam.h                  |  6 ++--
 include/exec/cpu-common.h              |  8 -----
 include/system/physmem.h               | 50 ++++++++++++++++++++++++++
 accel/kvm/kvm-all.c                    | 12 +++----
 dump/dump.c                            |  3 +-
 dump/win_dump-x86.c                    |  5 +--
 gdbstub/system.c                       | 11 +++---
 hw/acpi/ghes.c                         | 24 ++++++-------
 hw/acpi/nvdimm.c                       | 13 +++----
 hw/acpi/vmgenid.c                      |  3 +-
 hw/audio/marvell_88w8618.c             |  3 +-
 hw/char/riscv_htif.c                   |  5 +--
 hw/display/exynos4210_fimd.c           |  7 ++--
 hw/display/omap_lcdc.c                 |  5 +--
 hw/display/ramfb.c                     |  7 ++--
 hw/dma/i8257.c                         |  9 ++---
 hw/dma/omap_dma.c                      |  6 ++--
 hw/dma/rc4030.c                        |  3 +-
 hw/dma/sifive_pdma.c                   |  9 ++---
 hw/hyperv/hyperv.c                     | 25 ++++++-------
 hw/hyperv/syndbg.c                     | 13 +++----
 hw/hyperv/vmbus.c                      |  9 ++---
 hw/i386/kvm/clock.c                    |  3 +-
 hw/i386/vapic.c                        | 21 +++++------
 hw/intc/apic.c                         |  3 +-
 hw/intc/xive2.c                        |  3 +-
 hw/m68k/next-cube.c                    |  3 +-
 hw/microblaze/boot.c                   |  3 +-
 hw/misc/pc-testdev.c                   |  5 +--
 hw/net/fsl_etsec/rings.c               | 13 +++----
 hw/net/mcf_fec.c                       | 11 +++---
 hw/net/opencores_eth.c                 |  9 ++---
 hw/nvram/spapr_nvram.c                 |  9 ++---
 hw/ppc/amigaone.c                      |  5 +--
 hw/ppc/e500.c                          |  3 +-
 hw/ppc/pegasos.c                       | 11 +++---
 hw/ppc/pnv.c                           |  5 +--
 hw/ppc/ppc440_uc.c                     |  9 ++---
 hw/ppc/spapr.c                         |  3 +-
 hw/ppc/spapr_drc.c                     |  3 +-
 hw/ppc/spapr_events.c                  |  9 ++---
 hw/ppc/spapr_hcall.c                   | 17 ++++-----
 hw/ppc/spapr_rtas.c                    |  5 +--
 hw/ppc/spapr_tpm_proxy.c               |  5 +--
 hw/ppc/virtex_ml507.c                  |  3 +-
 hw/s390x/css.c                         |  5 +--
 hw/s390x/ipl.c                         |  9 ++---
 hw/s390x/s390-pci-bus.c                |  5 +--
 hw/s390x/virtio-ccw.c                  |  5 +--
 hw/scsi/vmw_pvscsi.c                   | 12 +++----
 hw/xen/xen_pt_graphics.c               |  4 +--
 hw/xtensa/xtfpga.c                     |  5 +--
 system/cpus.c                          |  3 +-
 system/physmem.c                       | 12 +++----
 target/s390x/diag.c                    | 43 ++++++++++++----------
 57 files changed, 310 insertions(+), 224 deletions(-)
Signature · 1 line
2.53.0