device property: fix child iteration issues with secondary fwnodes
Get series with b4
b4 am [email protected]Versions newest first
- v4 Latest3 patches 7 repliesIn review
Changes in v4 from the cover letter
- amended the fix and test case (Andy)
- added patch 2 to align other implementations with RAII approach (Andy)
- tested on Intel Galileo board for which the initial code was developed (Andy)
- Link to v3: https://patch.msgid.link/[email protected]
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | device property: fix infinite loop in fwnode_for_each_child_node()drivers/ | +16 | 1 reply | |
| 2/3 | device property: Refactor to use RAII approachdrivers/ | +8 | 2 replies | |
| 3/3 | device property: add test cases for fwnode_for_each_child_node()drivers/ drivers/ | +137 | 3 replies |
Reviews trailers per patch
None of the 3 patches has a Reviewed-by or Acked-by.
| Patch | Andy Shevchenko | Xu Yang |
|---|---|---|
| 1/3 | T-b | T-b |
| 2/3 | ||
| 3/3 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v4 0/3] device property: fix child iteration issues with secondary fwnodes
This series fixes two issues in the fwnode child iteration logic when a secondary fwnode is present.
The first issue is a refcount imbalance in software_node_get_next_child(). When a software node is used as a secondary fwnode, the iteration code may incorrectly decrement the refcount of child nodes that do not belong to the software node hierarchy. This results in refcount underflow and possible use-after-free.
The second issue is an infinite loop in fwnode_for_each_child_node(), caused by improper handling of iteration state across primary and secondary fwnodes. When iterating over children from both primary and secondary fwnodes, the code may incorrectly resume iteration from the primary fwnode even when the current child belongs to the secondary, leading to repeated traversal and a loop.
Both issues are triggered when mixing different fwnode types through the secondary mechanism, and stem from incorrect assumptions about ownership and traversal context of child nodes.
Changes in v4:
- amended the fix and test case (Andy)
- added patch 2 to align other implementations with RAII approach (Andy)
- tested on Intel Galileo board for which the initial code was developed (Andy)
- Link to v3: https://patch.msgid.link/[email protected]
Changes in v3:
- remove software node patch
- add a kunit test case suggested by Andy Shevchenko
- Link to v2: https://patch.msgid.link/[email protected]
Changes in v2:
- use __free() to cleanup parent fwnode
- Link to v1: https://lore.kernel.org/r/[email protected]
Andy Shevchenko (1):
device property: Refactor to use RAII approach
Xu Yang (2):
device property: fix infinite loop in fwnode_for_each_child_node() device property: add test cases for fwnode_for_each_child_node()
drivers/base/property.c | 41 ++++--- drivers/base/test/Kconfig | 1 + drivers/base/test/property-entry-test.c | 136 ++++++++++++++++++++++++ 3 files changed, 161 insertions(+), 17 deletions(-)
Signature · 1 line
2.50.1