Skip to content

platform/x86: msi-wmi: Fix unknown wmi event messages on MSI Claw models

Derek J. Clark lkml platform-driver-x86 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 2 repliesIn review
  2. v12 patches 6 repliesSuperseded

Changes in v2 from the cover letter

- Add comments explaining buffer fields & length.
- Test that we have at lease u8[2] before assignment of key ID
v1: https://lore.kernel.org/platform-driver-x86/[email protected]/
Derek J. Clark (2):
platform/x86: msi-wmi: Reformat msi_wmi_notify()
platform/x86: msi-wmi: Add MSI Claw M-Center keys

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2platform/x86: msi-wmi: Reformat msi_wmi_notify()drivers/platform/x86/msi-wmi.c+39 -320 replies
2/2platform/x86: msi-wmi: Add MSI Claw M-Center keysdrivers/platform/x86/msi-wmi.c+26 -00 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchArmin Wolf
SeriesR-b
1/2
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/2] platform/x86: msi-wmi: Fix unknown wmi event messages on MSI Claw models

MSI Claw devices produce WMI events through the MSI WMI hotkeys GUID for some of their buttons. When pressed, these cause spam in the kernel. The Claws use a GUID already supported by msi-wmi, but use an ACPI_TYPE_BUFFER instead of an ACPI_TYPE_INTEGER.

Patch 1 reformats msi_wmi_notify() to reduce nesting by using early returns and a switch case in preparation for handling this new data type.

Patch 2 adds known MSI Claw event keycodes to the keymap and support for ACPI_TYPE_BUFFER.

---
v2:
- Add comments explaining buffer fields & length.
- Test that we have at lease u8[2] before assignment of key ID
v1: https://lore.kernel.org/platform-driver-x86/[email protected]/
Derek J. Clark (2):
platform/x86: msi-wmi: Reformat msi_wmi_notify()
platform/x86: msi-wmi: Add MSI Claw M-Center keys

 drivers/platform/x86/msi-wmi.c | 97 +++++++++++++++++++++++-----------
 1 file changed, 65 insertions(+), 32 deletions(-)
Signature · 1 line
2.54.0