Skip to content

drm/solomon: batch command sequences for SSD130x/132x/133x init

Alberto Ruiz b4-sent dri-devel lkml 1 version Applied

Status from this message: Pushed to drm-misc (drm-misc-next). Thanks!

Get series with b4
b4 am [email protected] change-id 20260612-ssd-batchcmd-35f7ba8c1e8b

Versions newest first

  1. v1 Latest4 patches 2 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/4drm/solomon: add ssd130x_run_cmd_seq() for batch command executiondrivers/gpu/drm/solomon/ssd130x.c+43 -00 replies
2/4drm/solomon: use ssd130x_run_cmd_seq() in ssd130x_init()drivers/gpu/drm/solomon/ssd130x.c+26 -460 replies
3/4drm/solomon: use ssd130x_run_cmd_seq() in ssd132x_init()drivers/gpu/drm/solomon/ssd130x.c+27 -850 replies
4/4drm/solomon: use ssd130x_run_cmd_seq() in ssd133x_init()drivers/gpu/drm/solomon/ssd130x.c+30 -1060 replies

Reviews trailers per patch

None of the 4 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchJavier Martinez Canillas
SeriesR-b T-b
1/4
2/4
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/4] drm/solomon: batch command sequences for SSD130x/132x/133x init

The ssd130x_init(), ssd132x_init(), and ssd133x_init() functions each issue long chains of individual ssd130x_write_cmd() calls, each followed by its own error check. This is verbose and makes the init sequences harder to read and maintain.

This series introduces ssd130x_run_cmd_seq(), which interprets a flat byte array of length-prefixed command entries terminated by a zero byte, and converts the three init functions to use it. The result is a net reduction of ~110 lines, with the hardware programming sequences now expressed as compact, declarative tables rather than imperative call-and-check chains.

---
Alberto Ruiz (4):

      drm/solomon: add ssd130x_run_cmd_seq() for batch command execution
      drm/solomon: use ssd130x_run_cmd_seq() in ssd130x_init()
      drm/solomon: use ssd130x_run_cmd_seq() in ssd132x_init()
      drm/solomon: use ssd130x_run_cmd_seq() in ssd133x_init()
 drivers/gpu/drm/solomon/ssd130x.c | 367 +++++++++++++-------------------------
 1 file changed, 128 insertions(+), 239 deletions(-)

---
base-commit: 2b414a95b8f7307d42173ba9e580d6d3e2bcbfce
change-id: 20260612-ssd-batchcmd-35f7ba8c1e8b

Best regards,

Signature · 1 line
Alberto Ruiz <[email protected]>