Skip to content

Add two new system call mq_recvmmsg() and mq_sendmmsg() to posix ipc mqueue

Mathura_Kumar criu 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest posting 4/44 patches 2 repliesIn review
  2. v3 posting 3/44 patches 0 repliesSuperseded
  3. v3 posting 2/44 patches 1 replySuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v3 posting 1/44 patches4 repliesSuperseded

Changes in v3 from the cover letter

- iovec is introduced for arguments.
- since v2 does not contain batch operation and I introduced batch support now in recv or peek, due to that I added one more system call to support batch during send as well otherwise i don't see any benefites of having batching in consumer side only.

- the underlying tree structure used to store messages is augmented by introducing two additional fields on each node. This enables logarithmic-time complexity for peek operations and improves the efficiency of other tree traversals.

- some flaws in compat entry path fixed
- arguments mismatch in asmlinkages fixed
- copy_msg helper updated to be more safe for len arguments

- styles and formating improved
- test updated
- documentation is updated appropriately.
- v2 Link: https://lore.kernel.org/linux-arch/[email protected]/T/#t

Patches in v3 posting 4/4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4IPC: Added two new system call mq_recvmmsg() and mq_sendmmsg()include/linux/compat.h include/linux/syscalls.h include/uapi/asm-generic/unistd.h +6 more+616 -652 replies
2/4IPC: Added system call entry in all of most common architecturesarch/alpha/kernel/syscalls/syscall.tbl arch/arm/tools/syscall.tbl arch/arm64/tools/syscall_32.tbl +14 more+38 -10 replies
3/4IPC: Added system call entry in performance tooltools/include/uapi/asm-generic/unistd.h tools/perf/arch/alpha/entry/syscalls/syscall.tbl tools/perf/arch/arm/entry/syscalls/syscall.tbl +11 more+39 -10 replies
4/4Test: Added self-testing and documentationDocumentation/userspace-api/index.rst Documentation/userspace-api/mq_recvmmsg.rst Documentation/userspace-api/mq_sendmmsg.rst +4 more+1128 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH RESEND v3 0/4] Add two new system call mq_recvmmsg() and mq_sendmmsg() to posix ipc mqueue

Patch series overview:

1. Add New system call mq_recvmmsg(), mq_sendmmsg() and handler implementation.
2. Add system call number in all most common architectures.
3. Add entries in performance tools.
4. Prepared Documentation and test.

change since v2:
- iovec is introduced for arguments.
- since v2 does not contain batch operation and I introduced batch support now in recv or peek, due to that I added one more system call to support batch during send as well otherwise i don't see any benefites of having batching in consumer side only.

- the underlying tree structure used to store messages is augmented by introducing two additional fields on each node. This enables logarithmic-time complexity for peek operations and improves the efficiency of other tree traversals.

- some flaws in compat entry path fixed
- arguments mismatch in asmlinkages fixed
- copy_msg helper updated to be more safe for len arguments

- styles and formating improved
- test updated
- documentation is updated appropriately.
- v2 Link: https://lore.kernel.org/linux-arch/[email protected]/T/#t

Thanks for reviewing.

Mathura_Kumar (4):
IPC: Added two new system call mq_recvmmsg() and mq_sendmmsg()
IPC: Added system call entry in all of most common architectures
IPC: Added system call entry in performance tool
Test: Added self-testing and documentation

 Documentation/userspace-api/index.rst         |   2 +
 Documentation/userspace-api/mq_recvmmsg.rst   | 205 +++++++
 Documentation/userspace-api/mq_sendmmsg.rst   | 168 ++++++
 arch/alpha/kernel/syscalls/syscall.tbl        |   2 +
 arch/arm/tools/syscall.tbl                    |   2 +
 arch/arm64/tools/syscall_32.tbl               |   3 +
 arch/m68k/kernel/syscalls/syscall.tbl         |   2 +
 arch/microblaze/kernel/syscalls/syscall.tbl   |   2 +
 arch/mips/kernel/syscalls/syscall_n32.tbl     |   2 +
 arch/mips/kernel/syscalls/syscall_n64.tbl     |   3 +
 arch/mips/kernel/syscalls/syscall_o32.tbl     |   2 +
 arch/parisc/kernel/syscalls/syscall.tbl       |   2 +
 arch/powerpc/kernel/syscalls/syscall.tbl      |   2 +
 arch/s390/kernel/syscalls/syscall.tbl         |   3 +
 arch/sh/kernel/syscalls/syscall.tbl           |   2 +
 arch/sparc/kernel/syscalls/syscall.tbl        |   3 +
 arch/x86/entry/syscalls/syscall_32.tbl        |   2 +
 arch/x86/entry/syscalls/syscall_64.tbl        |   3 +-
 arch/xtensa/kernel/syscalls/syscall.tbl       |   2 +
 include/linux/compat.h                        |  12 +-
 include/linux/syscalls.h                      |  10 +
 include/uapi/asm-generic/unistd.h             |   9 +-
 include/uapi/linux/mqueue.h                   |  27 +-
 ipc/mqueue.c                                  | 564 +++++++++++++++++-
 ipc/msg.c                                     |   2 +-
 ipc/msgutil.c                                 |  45 +-
 ipc/util.h                                    |   3 +-
 kernel/sys_ni.c                               |   6 +
 scripts/syscall.tbl                           |   2 +
 tools/include/uapi/asm-generic/unistd.h       |   8 +-
 .../arch/alpha/entry/syscalls/syscall.tbl     |   4 +
 .../perf/arch/arm/entry/syscalls/syscall.tbl  |   3 +
 .../arch/arm64/entry/syscalls/syscall_32.tbl  |   3 +
 .../arch/mips/entry/syscalls/syscall_n64.tbl  |   2 +
 .../arch/parisc/entry/syscalls/syscall.tbl    |   3 +
 .../arch/powerpc/entry/syscalls/syscall.tbl   |   3 +
 .../perf/arch/s390/entry/syscalls/syscall.tbl |   2 +
 tools/perf/arch/sh/entry/syscalls/syscall.tbl |   2 +
 .../arch/sparc/entry/syscalls/syscall.tbl     |   2 +
 .../arch/x86/entry/syscalls/syscall_32.tbl    |   2 +
 .../arch/x86/entry/syscalls/syscall_64.tbl    |   2 +
 .../arch/xtensa/entry/syscalls/syscall.tbl    |   2 +
 tools/scripts/syscall.tbl                     |   2 +
 tools/testing/selftests/ipc/Makefile          |   2 +-
 tools/testing/selftests/ipc/mq_recvmmsg.c     | 391 ++++++++++++
 tools/testing/selftests/ipc/mq_sendmmsg.c     | 360 +++++++++++
 46 files changed, 1818 insertions(+), 67 deletions(-)
 create mode 100644 Documentation/userspace-api/mq_recvmmsg.rst
 create mode 100644 Documentation/userspace-api/mq_sendmmsg.rst
 create mode 100644 tools/testing/selftests/ipc/mq_recvmmsg.c
 create mode 100644 tools/testing/selftests/ipc/mq_sendmmsg.c
Signature · 1 line
2.43.0