ipv4: fib: Remove RTNL in fib_net_exit_batch().
Status from this message: This series was applied to netdev/net-next.git (main)
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 All 5 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | ipv4: fib: Flush all fib_info in fib_table_flush() during netns dismantle.net/ | +2 | 1 reply | Applied |
| 2/5 | ipv4: fib: Call fib_proc_exit() and nl_fib_lookup_exit() at ->pre_exit().net/ | +2 | 1 reply | Applied |
| 3/5 | ipv4: fib: Free net->ipv4.{fib_table_hash,notifier_ops} without RTNL.net/ | +7 | 1 reply | Applied |
| 4/5 | ipv4: fib: Avoid calling fib_trie_table() in fib_new_table() for dying net.net/ | +2 | 1 reply | Applied |
| 5/5 | ipv4: fib: Convert fib_net_exit_batch() to ->exit_rtnl().net/ | +12 | 1 reply | Applied |
Reviews trailers per patch
All 5 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Ido Schimmel | Eric Dumazet |
|---|---|---|
| Series | R-b | |
| 1/5 | R-b | |
| 2/5 | R-b | |
| 3/5 | R-b | |
| 4/5 | R-b | |
| 5/5 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v1 net-next 0/5] ipv4: fib: Remove RTNL in fib_net_exit_batch().
Currently, we flush all IPv4 routes at ->exit_batch() during netns dismantle, which requires an extra RTNL.
IPv4 routes are not added from the fast path unlike IPv6, so we can flush routes before default_device_exit_batch().
However, there is implicit ordering between ip_fib_net_exit() and default_device_exit_batch().
This series detangles it and moves ip_fib_net_exit() to
->exit_rtnl() to save the RTNL dance.
The same change for IPv6 will need more work.
Kuniyuki Iwashima (5):
ipv4: fib: Flush all fib_info in fib_table_flush() during netns
dismantle.
ipv4: fib: Call fib_proc_exit() and nl_fib_lookup_exit() at
->pre_exit().
ipv4: fib: Free net->ipv4.{fib_table_hash,notifier_ops} without RTNL.
ipv4: fib: Avoid calling fib_trie_table() in fib_new_table() for dying
net.
ipv4: fib: Convert fib_net_exit_batch() to ->exit_rtnl().
net/ipv4/fib_frontend.c | 37 ++++++++++++++++++------------------- net/ipv4/fib_trie.c | 10 ++-------- 2 files changed, 20 insertions(+), 27 deletions(-)
Signature · 1 line
2.54.0.1136.gdb2ca164c4-goog