Skip to content

HID: asus: security fixes and more hardware support

Denis Benato linux-input lkml 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest5 patches 6 repliesIn review
  2. v45 patches 9 repliesSuperseded
  3. v38 patches 6 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v24 patches7 repliesSuperseded

Changelog from the cover letter · 33 lines

- v1
- Initial submission (as separate patches)
- v2
- HID: asus: add i2c entry for FA808UM and other TUFs
- Joined to the patchset
- HID: asus: add support for xgm led
- Use the correct callback set_brightness_blocking
- Stop hardcoding the cled name
- HID: asus: prevent wrong pointer cast
- Added
- HID: asus: mitigate possible use-after-free
- Added
- v3
- HID: asus: add support for xgm led
- check devm_kasprintf result
- HID: asus: prevent a late KEY_FN_ESC to trigger a use-after-free
- Added
- HID: asus: avoid sleeping calls in atomic context
- Added
- HID: asus: cleanup keyboard listener on failure: avoid use-after-free
- Added
- v4
- HID: asus: refactor the two workqueues and init sequence
- Added to replace previous patches in a clearer way
- HID: asus: add support for xgm led
- Simplify cled interface allocation and registration
- v5
- HID: asus: refactor the two workqueues and init sequence
- replace kzalloc_obj in atomix context with kzalloc(..., GFP_ATOMIC/NOWAIT)
- better destroy the queue on _probe in case of errors
- Fix a data race for deferred asus_kbd_wmi_fan()
- HID: asus: add support for xgm led
- improve teardown of the cled interface

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5HID: asus: refactor the two workqueues and init sequencedrivers/hid/hid-asus.c+289 -1110 replies
2/5HID: asus: remove extraneous OOM errordrivers/hid/hid-asus.c+1 -30 replies
3/5HID: asus: fix a off-by-one in mcu_parse_version_string() validationdrivers/hid/hid-asus.c+1 -10 replies
4/5HID: asus: add support for xgm leddrivers/hid/hid-asus.c+94 -00 replies
5/5HID: asus: add i2c entry for FA808UM and other TUFsdrivers/hid/hid-asus.c+3 -00 replies

Reviews trailers per patch

2 of 5 patches have a Reviewed-by or Acked-by.

PatchAntheas Kapenekakis
1/5
2/5R-b
3/5
4/5R-b
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 0/5] HID: asus: security fixes and more hardware support

Hi all,

I have added support for controlling the (way too bright) XG mobile LEDs in hid-asus and added the i2c version of already supported hardware that was probed only when it's a USB: these are two separate features changes and are the only two that are not fixes for pre-existing issue (see below).

Auto-review bot has spotted a bunch of pre-existing problems alongside problems in my own code therefore at this point I am going to fix the more problems I can and including those fixes and improvements in this patchset.

For v4 I decided to follow Antheas' suggestion of reusing the existing workqueue and by making it more generic I solved a good bunch of issues.

The v5 iteration is simply me fixing a bunch of bugs in new code spotted by the bot. Thanks for providing such a useful tool!

On a side node this patchset has a few more warnings: specifically "WARNING: Prefer kzalloc_obj over kzalloc with sizeof" but it's a false positive as that would introduce sleeping calls in atomic contexts.

Best regards,
Denis Benato

Link v2: https://lore.kernel.org/all/[email protected]/
Link v3: https://lore.kernel.org/all/[email protected]/
Link v4: https://lore.kernel.org/all/[email protected]/

Changelog:
- v1
- Initial submission (as separate patches)
- v2
- HID: asus: add i2c entry for FA808UM and other TUFs
- Joined to the patchset
- HID: asus: add support for xgm led
- Use the correct callback set_brightness_blocking
- Stop hardcoding the cled name
- HID: asus: prevent wrong pointer cast
- Added
- HID: asus: mitigate possible use-after-free
- Added
- v3
- HID: asus: add support for xgm led
- check devm_kasprintf result
- HID: asus: prevent a late KEY_FN_ESC to trigger a use-after-free
- Added
- HID: asus: avoid sleeping calls in atomic context
- Added
- HID: asus: cleanup keyboard listener on failure: avoid use-after-free
- Added
- v4
- HID: asus: refactor the two workqueues and init sequence
- Added to replace previous patches in a clearer way
- HID: asus: add support for xgm led
- Simplify cled interface allocation and registration
- v5
- HID: asus: refactor the two workqueues and init sequence
- replace kzalloc_obj in atomix context with kzalloc(..., GFP_ATOMIC/NOWAIT)
- better destroy the queue on _probe in case of errors
- Fix a data race for deferred asus_kbd_wmi_fan()
- HID: asus: add support for xgm led
- improve teardown of the cled interface

Denis Benato (5):
HID: asus: refactor the two workqueues and init sequence
HID: asus: remove extraneous OOM error
HID: asus: fix a off-by-one in mcu_parse_version_string() validation
HID: asus: add support for xgm led
HID: asus: add i2c entry for FA808UM and other TUFs

 drivers/hid/hid-asus.c | 491 ++++++++++++++++++++++++++++++++---------
 1 file changed, 382 insertions(+), 109 deletions(-)
Signature · 1 line
2.47.3