fs/ceph: optimize struct layouts
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 Latest11 patches 4 repliesIn review
- v412 patches 1 replySuperseded
- v312 patches 1 replySuperseded
Earlier versions · 2
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v2 | 18 patches | 0 replies | Superseded | |
| v1 | 12 patches | 10 replies | Superseded |
Changes in v5 from the cover letter
- drop "Fixes" tag from "i_cap_migration_resv" patch
- fix multi-line comment style
- drop the "pool_id" 32 bit patch (may break RBD)
Patches in v5 No applies recorded yet
Reviews trailers per patch
None of the 11 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Alex Markuze |
|---|---|
| Series | R-b |
| 1/11 | |
| 2/11 | |
| 3/11 | |
| 4/11 | |
| 5/11 | |
| 6/11 | |
| 7/11 | |
| 8/11 | |
| 9/11 | |
| 10/11 | |
| 11/11 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v5 00/11] fs/ceph: optimize struct layouts
This patch set aims to reduce the memory usage of the Ceph filesystems by optimizing the layout of structs, most importantly struct ceph_inode_info:
- use bool instead of int for booelans
- use u32 instead of u64 where possible
- reorder fields to eliminate padding holes
- eliminate redundant fields
Without this patch set, ceph_inode_info looks like this with pahole:
/* size: 1456, cachelines: 23, members: 79 */ /* sum members: 1424, holes: 8, sum holes: 32 */ /* member types with holes: 3, total: 3 */
With this patch set, struct ceph_inode_info got smaller by 96 bytes:
/* size: 1360, cachelines: 22, members: 76 */ /* member types with holes: 1, total: 1 */
struct ceph_cap shrinks by 24 bytes:
/* size: 120, cachelines: 2, members: 12 */ /* size: 96, cachelines: 2, members: 10 */
struct ceph_snap_realm shrinks by 24 bytes, too:
/* size: 232, cachelines: 4, members: 21 */ /* sum members: 216, holes: 3, sum holes: 12 */ /* size: 208, cachelines: 4, members: 20 */
---v1->v2:
- fix CONFIG_FS_ENCRYPTION check in "i_truncate_pagecache_size" patch
- add patches to shrink ceph_cap and ceph_snap_realmv2->v3:
- rebase on latest masterv3->v4:
- drop the buggy ceph_in_snap() change from ceph_d_prune()
- fix -Wunused-variable on BITS_PER_LONG<64v4->v5:
- drop "Fixes" tag from "i_cap_migration_resv" patch
- fix multi-line comment style
- drop the "pool_id" 32 bit patch (may break RBD)
Max Kellermann (11):
fs/ceph/super: remove unused field i_cap_migration_resv fs/ceph/super: make field i_truncate_pagecache_size optional fs/ceph/super.h: convert ceph_inode_xattr fields to bool fs/ceph/super.h: convert ceph_cap_snap.writing fields to bool fs/ceph: consistently use u32 for time_warp_seq fs/ceph/super: reorder fields to eliminate padding holes fs/ceph: remove i_truncate_mutex, use i_fragtree_mutex for both fs/ceph/super.h: add const to helpers fs/ceph/super.h: add helper ceph_in_snap()
fs/ceph: use ceph_vino() etc. instead of accessing i_vino directly fs/ceph: remove redundant inode number from ceph_inode_info
fs/ceph/acl.c | 2 +- fs/ceph/addr.c | 7 ++- fs/ceph/cache.c | 4 +- fs/ceph/caps.c | 6 +-- fs/ceph/dir.c | 20 ++++----- fs/ceph/export.c | 8 ++-- fs/ceph/file.c | 28 ++++++------ fs/ceph/inode.c | 38 ++++++++++------ fs/ceph/mds_client.c | 12 ++--- fs/ceph/quota.c | 6 +-- fs/ceph/snap.c | 8 ++-- fs/ceph/super.h | 103 +++++++++++++++++++++++++++++++------------ fs/ceph/xattr.c | 8 ++-- 13 files changed, 156 insertions(+), 94 deletions(-)
Signature · 1 line
2.47.3