Skip to content

net: bcmgenet: collapse TX priority queues

Nicolai Buchwitz lkml netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 8 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3net: bcmgenet: collapse TX priority queues to a single queuedrivers/net/ethernet/broadcom/genet/bcmgenet.c+6 -62 replies
2/3net: bcmgenet: remove dead priority queue plumbingdrivers/net/ethernet/broadcom/genet/bcmgenet.c drivers/net/ethernet/broadcom/genet/bcmgenet.h+9 -772 replies
3/3net: bcmgenet: allocate a single-queue netdevdrivers/net/ethernet/broadcom/genet/bcmgenet.c+1 -32 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchJustin ChenFlorian Fainelli
1/3R-b T-b R-b
2/3R-b T-b R-b
3/3R-b T-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH net-next 0/3] net: bcmgenet: collapse TX priority queues

The strict-priority TX queues can starve under multi-queue load and trip NETDEV_WATCHDOG. Justin's earlier series [1] tried to mitigate the timeouts but kept the multi-queue design. Ovidiu Panait recently proposed a WRR stop-gap [2]. This series drops the priority queues entirely. Justin confirmed they are no longer required.

Patch 1 collapses v2-v4 hw_params to the same single-queue path v1 already uses. Patch 2 removes the now-dead priority register writes, helper macros, and the dead "flow period for ring != 0" branch in bcmgenet_init_tx_ring(); the DMA_ARBITER_{RR,WRR,SP} and DMA_RING_BUF_PRIORITY_* HW defines are kept as register documentation. Patch 3 switches the netdev allocation from alloc_etherdev_mqs(., 5, 5) to alloc_etherdev(), since only one TX/RX queue is ever used.

Tested on Raspberry Pi CM4 (BCM2711):
- Ovidiu's reproducer (iperf3 -u -b0 -P16 -t60) no longer trips NETDEV_WATCHDOG.
- UDP sustains 956 Mbit/s line rate over 60 s with 0 datagrams

    lost (0/4952890).

- Single-stream TCP throughput unchanged at 943 Mbit/s.

[1] https://lore.kernel.org/netdev/[email protected]/
[2] https://lore.kernel.org/netdev/[email protected]/

Nicolai Buchwitz (3):
net: bcmgenet: collapse TX priority queues to a single queue
net: bcmgenet: remove dead priority queue plumbing
net: bcmgenet: allocate a single-queue netdev

 .../net/ethernet/broadcom/genet/bcmgenet.c    | 100 +++---------------
 .../net/ethernet/broadcom/genet/bcmgenet.h    |   2 -
 2 files changed, 16 insertions(+), 86 deletions(-)
Signature · 1 line
2.53.0