Skip to content

Add vm_bind param check to ensure no overlap with kbo AS carveout

Adrián Larumbe dri-devel lkml 6 versions – In review

Get series with b4
b4 am [email protected] change-id 20260614-vm_bind_checks-46075ba069a0

Versions newest first

  1. v6 Latest2 patches 1 replyIn review
  2. v52 patches 2 repliesSuperseded
  3. v43 patches 6 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v34 patches3 repliesSuperseded
v22 patches8 repliesSuperseded
v12 patches4 repliesSuperseded

Changes in v6 from the cover letter

- Filled in 'Fixes' commit tag for first patch in the series.
- Link to v5: https://patch.msgid.link/[email protected]

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2drm/panthor: Add vm_bind region with kbo range overlap checkdrivers/gpu/drm/panthor/panthor_mmu.c+9 -01 reply
2/2drm/panthor: Fix comment to reflect actual struct field namedrivers/gpu/drm/panthor/panthor_mmu.c+1 -10 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchBoris BrezillonSteven PriceLiviu Dudau
1/2R-b R-b
2/2R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v6 thread

Cover letter [PATCH v6 0/2] Add vm_bind param check to ensure no overlap with kbo AS carveout

Just a quick check to make sure user-supplied vm_bind regions aren't clashing with the region reserved for kernel bo's.

I tried to introduce a similar check for panthor_vm_alloc_va(), to throw back an error when mappings of kernel bo's against specific addresses fall within the auto_va region. However that is not possible, since there's one FW region that must be mapped right at CSF_MCU_SHARED_REGION_START. That is usually not a problem, since drm_mm_insert_node_in_range() will pick the next one available.

v3 also comes with an early bind range overflow check for sparse mappings.

---
Changes in v6:
- Filled in 'Fixes' commit tag for first patch in the series.
- Link to v5: https://patch.msgid.link/[email protected]

Changes in v5:
- Coalesced uint64 and kbo ranges overflow checks into a single patch.
- Link to v4: https://patch.msgid.link/[email protected]

Changes in v4:
- Deleted commit that passes single operation to panthor_vm_prepare_unmap_op_ctx.
- Moved overflow check one step above in the call stack.
- Rearranged the commits in the series.
- Link to v3: https://patch.msgid.link/[email protected]

Changes in v3:
- Fixed off-by-one error for user va range calculations.
- Added new commit for panthor_vm_prepare_unmap_op_ctx to take a whole operation.
- Added commit with bind range early overflow check.
- Link to v2: https://patch.msgid.link/[email protected]

Changes in v2:
- Simplified user VA range with kernel BO range overlap to a single statement.
- Link to v1: https://patch.msgid.link/[email protected]

To: Boris Brezillon <[email protected]>
To: Steven Price <[email protected]>
To: Liviu Dudau <[email protected]>
To: Maarten Lankhorst <[email protected]>
To: Maxime Ripard <[email protected]>
To: Thomas Zimmermann <[email protected]>
To: David Airlie <[email protected]>
To: Simona Vetter <[email protected]>
To: Heiko Stuebner <[email protected]>
To: Grant Likely <[email protected]>
To: Adrián Larumbe <[email protected]>
Cc: [email protected]
Cc: [email protected]

---
Adrián Larumbe (2):
drm/panthor: Add vm_bind region with kbo range overlap check drm/panthor: Fix comment to reflect actual struct field name

 drivers/gpu/drm/panthor/panthor_mmu.c | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

---
base-commit: 35fff4830cb999b5496ae892a85516fef2912438
change-id: 20260614-vm_bind_checks-46075ba069a0

Best regards,

Signature · 1 line
Adrián Larumbe <[email protected]>