Skip to content

wifi: rtlwifi: fix ASPM AER flooding on RTL8723BE devices

William Hansen-Baird linux-wireless lkml 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest3 patches 1 replyIn review
  2. v33 patches 2 repliesSuperseded
  3. v23 patches 4 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v13 patches5 repliesSuperseded

Changes in v4 from the cover letter

- Patch 1: remove trailing whitespace
- Patch 2: remove space from {} in rtl_aspm_quirks table
- Carry forward Acked-by from v3 for Patch 1 and 2

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3wifi: rtlwifi: fix disabling of ASPM for RTL8723BE with AER floodingdrivers/net/wireless/realtek/rtlwifi/pci.c+26 -131 reply
2/3wifi: rtlwifi: convert pci if-statement to ID tabledrivers/net/wireless/realtek/rtlwifi/pci.c+8 -60 replies
3/3wifi: rtlwifi: disable ASPM for RTL8723BE with subsystem ID 17aa:b736drivers/net/wireless/realtek/rtlwifi/pci.c+2 -00 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchPing-Ke Shih
1/3A-b
2/3A-b
3/3A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH rtw-next v4 0/3] wifi: rtlwifi: fix ASPM AER flooding on RTL8723BE devices

This series fixes AER error message flooding and system slowdown caused by RTL8723BE with subsystem ID 17aa:b736. The flood is found to be caused by ASPM, and disabling it stops the AER spam.

This flood of AER error messages for the RTL8723BE is not unique to
subsystem ID 17aa:b736.
Commit 77a6407c6ab2 ("wifi: rtlwifi: disable ASPM for RTL8723BE with subsystem ID 11ad:1723") targets the same issue for subsystem ID 11ad:1723.
The fix applied in that commit, however, does not correctly
disable ASPM. It merely disables driver control of ASPM.

Patch 1 fixes the previous commit such that it properly disables ASPM for subsystem ID 11ad:1723.

Patch 2 converts the if-statement check of subsystem IDs to a rtl_aspm_quirks pci_device_id table matched with pci_match_id() such that future devices can easily be added if they have the same error.

Patch 3 adds the RTL8723BE with subsystem ID 17aa:b736 to the rtl_aspm_quirks table to disable ASPM for it. Testing on a Razer Blade 14 2017 showed this stops the AER error message flood and wifi works as it should.

---
v4:
- Patch 1: remove trailing whitespace
- Patch 2: remove space from {} in rtl_aspm_quirks table
- Carry forward Acked-by from v3 for Patch 1 and 2

v3:
- Replace { 0 } with { } in rtl_pci_quirks table as recommended by Uwe and requested by Ping-Ke
- Added comments to rtl_pci_quirks table describing what machine correspond to the pci ids
- Replace net-specific comment style with wireless comment style
- Removed misleading Fixes tag from patch 1.
- Patch 3: carried forward Acked-by from v2

v2:
- Implement __rtl_pci_disable_aspm() in patch 1 which disables ASPM without checking ppsc->support_aspm.
This is called both by rtl_pci_disable_aspm(), guarded by the original check of ppsc->support_aspm, and the new quirk code.
- Rename rtl8723be_aspm_quirks to rtl_aspm_quirks and fill out system vendor and device ID alongside subsystem vendor and device ID in the rtl_aspm_quirks table such that we can use pci_match_id() alone without the RTL8723BE check.

William Hansen-Baird (3):
wifi: rtlwifi: fix disabling of ASPM for RTL8723BE with AER flooding
wifi: rtlwifi: convert pci if-statement to ID table
wifi: rtlwifi: disable ASPM for RTL8723BE with subsystem ID 17aa:b736

 drivers/net/wireless/realtek/rtlwifi/pci.c | 43 +++++++++++++++-------
 1 file changed, 30 insertions(+), 13 deletions(-)
Signature · 1 line
2.54.0