of/fdt, LoongArch, MIPS: fix misleading reservation success message
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest3 patches 2 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | of/fdt: fix misleading elfcorehdr reservation success messagedrivers/ | +4 | 2 replies | |
| 2/3 | LoongArch: fix misleading elfcorehdr reservation success messagearch/ | +4 | 0 replies | |
| 3/3 | MIPS: fix misleading elfcorehdr reservation success messagearch/ | +5 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/3] of/fdt, LoongArch, MIPS: fix misleading reservation success message
While reading the elfcorehdr reservation paths I noticed that fdt_reserve_elfcorehdr(), LoongArch's arch_reserve_vmcore() and MIPS's mips_reserve_vmcore() ignore the return value of memblock_reserve() and print a success message even when the reservation fails.
memblock_reserve() is unlikely to fail this early in boot. However, printing success on a failed reservation is misleading. I think it is worth fixing, but feel free to drop it if you disagree.
The three call sites are in different trees, so I split the change into one patch per arch/subsystem. The patches are independent and can be applied separately.
Sang-Heon Jeon (3):
of/fdt: fix misleading elfcorehdr reservation success message
LoongArch: fix misleading elfcorehdr reservation success message
MIPS: fix misleading elfcorehdr reservation success message
arch/loongarch/kernel/setup.c | 5 ++++- arch/mips/kernel/setup.c | 7 +++++-- drivers/of/fdt.c | 5 ++++- 3 files changed, 13 insertions(+), 4 deletions(-)
Signature · 1 line
2.43.0